BUG: 416072
Since the Milou/Search applet changed its icon from 'nepomuk' to 'search', the Breeze and Air/Oxygen Plasma Themes no longer theme that Plasmoid icon. This patch fixes that by renaming the themed icons to theme the Milou Plasmoid once more.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 20919 | |
| Build 20937: arc lint + arc unit |
I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes
This is a fix to it happening in real-time in Plasmashell - me making this patch is not related to a potential issue with Widget Explorer. However, I could easily edit this patch to retain the nepomuk icons alongside the renamed ones if needed.
But if I understood it right this patch is a reaction to an issue caused by changing the icon which was caused by the widget explorer issue?
I honestly haven't heard about the potential Widget Factory issue side of it, but this patch was definitely made because the Milou Plasmoid changed its icon from 'nepomuk' to 'search'.
Icons in the desktop theme that are made to replace icons in the icon theme need to be kept up to date with the icon theme. I'm accepting this as it is, but if @davidre thinks we should continue to support the use of the nepomuk icon name, then include both in the desktop theme. If this seems inelegant, that's because comprehensive icon support is not very pretty, technically. breeze-icons is filled with tons of symlinks for compatibility and there's really nothing we can do about it.
If anyone has any issues with removing the 'nepomuk' icon theming, please be sure to let me know so I can add them back in again on this patch to be alongside the 'search' theming to sort that issue out.
It appears that no 1st-party Plasmoids I can see in Plasma have the nepomuk icon now, so the only potential issue I can currently see is the loss of theming for 3rd-party Search Plasmoids.
Are we sure this is the right approach? In the Breeze theme, the icon is the same as the generic magnifying glass search icon, but in the Oxygen and Breeze theme, it's some kind of paint splatter, which as @bruns suggests, is not appropriate to use as a generic search icon.
How is anything still using this icon anyway? I thought milou switched to using the search icon? This should fall back to the icon in the Breeze theme.
If we need a search icon in the plasma theme, then we need to make sure it's semantically appropriate. For Breeze, it should be a line-art magnifying glass, for Oxygen, it should be a skeumorphic magnifying glass, etc.
Hmph... Oxygen has a low-quality 'search' icon. I'll update the diff again in a bit to add a higher quality version of the icon in SVG form if I can find a higher quality SVG of the icon from Oxygen.
*sigh* It seems scour-icon decided to nuke the layer names that made the icons identifiable, working on fixing that now.
Rename 'nepomuk' Plasma Theme icons to 'search' and redesign Oxygen/Air 'search' icon
There we go. Noticed there was a slight imperfection with the icon alignment in the previous edit so fixed that.
Looks like this needs a bit of CMake work to stop installing the old icons:
# from directory: /home/nate/kde/build/plasma-framework gmake[2]: *** No rule to make target '/home/nate/kde/src/plasma-framework/src/desktoptheme/air/icons/nepomuk.svg', needed by 'src/desktoptheme/oxygen/oxygen.gzipped/icons/nepomuk.svgz'. Stop. gmake[1]: *** [CMakeFiles/Makefile2:880: src/desktoptheme/oxygen/CMakeFiles/oxygen_desktoptheme_graphics_icons.dir/all] Error 2
Probably need to add the new ones too.
Hmm, can't seem to find any mentions of 'nepomuk' anywhere in the repos nor in the files...
@ngraham - the icons are picked up by a glob, https://phabricator.kde.org/source/plasma-framework/browse/master/src/desktoptheme/air/CMakeLists.txt$30, probably just some stale CMake cache on your side? Can you recheck?