- emit changed with good value to ensure reset button is activated only when needed
- add defaulted signal to activate dafault button only when needed
Details
- Reviewers
ervin crossi meven - Group Reviewers
Plasma - Commits
- R295:6d6e2427f8e2: Update KPluginSelector to allow KCM to show good state for reset, apply and…
Diff Detail
- Repository
- R295 KCMUtils
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Apart from @since version, seems fine to me
src/kpluginselector.h | ||
---|---|---|
234 | 5.67, 5.66 was released saturday |
src/kpluginselector.cpp | ||
---|---|---|
286 | We generally don't "this->", also you're capturing too much with =, capturing this would be enough. | |
388 | No need for the extra blank line | |
389 | This logic looks wrong to me. isChanged indicates if an entry state was changed during the course of the call to defaults(). It's very possible it's false when getting out of the loop. I think in such a case we'd loose the information of being in a "dirty" state while defaults() wouldn't have changed state at all. | |
src/kpluginselector.h | ||
241 | nitpick: Shouldn't be here | |
src/kpluginselector_p.h | ||
205 | Either this is unused or this doesn't compile/run properly. Indeed, this signature changed but no other code has been adjusted to match it. |
src/kpluginselector.cpp | ||
---|---|---|
389 | I thought that was the current GUI state not the current storage state and got confused. I stand corrected. |
src/kpluginselector_p.h | ||
---|---|---|
205 | Right, I missed the relevant connect. |