Differential D26360

[Kuit] Port QRegExp to QRegularExpression, second pass
ClosedPublic
Actions

Authored by ahmadsamir on Jan 2 2020, 9:45 AM.

Details

Reviewers
ilic
dfaure
mlaurent
aacid
apol
Group Reviewers
Frameworks
Commits
R249:52cb9a5c2aaa: [Kuit] Port QRegExp to QRegularExpression, second pass
Summary

Port KuitStaticData::toKeyCombo() and KuitStaticData::toInterfacePath()
to QRegularExpression.

Test Plan

make && ctest

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Jan 2 2020, 9:45 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 2 2020, 9:45 AM
ahmadsamir requested review of this revision.Jan 2 2020, 9:45 AM
apol added a subscriber: apol.Jan 2 2020, 12:27 PM
apol added inline comments.
src/kuitmarkup.cpp
412

Why did you change [i] to at(i)?

ahmadsamir added inline comments.Jan 2 2020, 12:32 PM
src/kuitmarkup.cpp
412

According to the QList docs, at() should be used for read-only access, it could be faster than [] and it never causes a detach.

apol accepted this revision.Jan 2 2020, 7:35 PM
apol added inline comments.
src/kuitmarkup.cpp
412

I'd do these changes in a separate commit. Also adding consts to unrelated variables.

This revision is now accepted and ready to land.Jan 2 2020, 7:35 PM
ahmadsamir updated this revision to Diff 72647.Jan 2 2020, 8:11 PM

Make the diff less noisy, split unrelated optimisations in a separate commit

Closed by commit R249:52cb9a5c2aaa: [Kuit] Port QRegExp to QRegularExpression, second pass (authored by ahmadsamir). · Explain WhyJan 2 2020, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kuitmarkup.cpp (29 lines)

Diff 72648

View Options

src/kuitmarkup.cpp

Loading...