Differential D26213

Exclude daemonized processes from Dolphin::attachToExistingInstance()
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 24 2019, 5:55 PM.

Details

Reviewers

ngraham

Group Reviewers

Dolphin

Commits

R318:fa806d48dafe: Exclude daemonized processes from Dolphin::attachToExistingInstance()

Summary

dolphin --daemon does not have the /dolphin/Dolphin_1 dbus path,
because it doesn't have any DolphinMainWindow.

Instead of working around this issue (as we did in D21666 and D25510),
just exclude these processes from the list of dbus instances checked by
Dolphin::attachToExistingInstance().

CCBUG: 408244

Test Plan

Same test plan as in D21666 and D25510

Diff Detail

Repository

R318 Dolphin

Branch

deamon-refactor (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20294
Build 20312: arc lint + arc unit

elvisangelaccio created this revision.Dec 24 2019, 5:55 PM

Restricted Application added a project: Dolphin. · View Herald TranscriptDec 24 2019, 5:55 PM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

elvisangelaccio requested review of this revision.Dec 24 2019, 5:55 PM

Harbormaster completed remote builds in B20251: Diff 72151.Dec 24 2019, 5:55 PM

elvisangelaccio added a dependent revision: D26214: Switch to generated MainWindow dbus interface.Dec 24 2019, 5:59 PM

anthonyfieroni added a subscriber: anthonyfieroni.Dec 25 2019, 6:10 AM

anthonyfieroni added inline comments.

src/dbusinterface.h
39	Since you can't switch from daemon to non-daemon or vice versa, it should be setAsDaemon (getting no parameters or inject it as constructor parameter)

Improve API

Harbormaster completed remote builds in B20294: Diff 72217.Dec 26 2019, 5:59 PM

elvisangelaccio added inline comments.Dec 26 2019, 6:00 PM

src/dbusinterface.h
39	Good point

ngraham accepted this revision.Mar 16 2020, 3:52 PM

This revision is now accepted and ready to land.Mar 16 2020, 3:52 PM

Closed by commit R318:fa806d48dafe: Exclude daemonized processes from Dolphin::attachToExistingInstance() (authored by elvisangelaccio). · Explain WhyMar 16 2020, 9:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/dbusinterface.h (13 lines)
M			src/dbusinterface.cpp (14 lines)
M			src/global.h (4 lines)
M			src/global.cpp (2 lines)
M			src/main.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72151	224028d		Dec 24 2019, 5:55 PM	★	★
Diff 2	72217	984e868	Improve API	Dec 26 2019, 5:59 PM	★	★
Diff 3	77786	405dd62	R318:fa806d48dafec0c47141381740a5d7604293d32d	Mar 16 2020, 9:38 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e767120028ef	c3eed90813bb	984e8686e8ff	Elvis Angelaccio	Exclude daemonized processes from Dolphin::attachToExistingInstance() (Show More…)	Dec 24 2019, 5:28 PM

	Status	Author	Revision
	Closed	elvisangelaccio	D26214 Switch to generated MainWindow dbus interface
	Closed	elvisangelaccio	D26213 Exclude daemonized processes from Dolphin::attachToExistingInstance()