Require Qt 5.12 for QRegularExpression::anchoredPattern()
Details
Details
- Reviewers
mlaurent dfaure apol - Group Reviewers
Frameworks - Maniphest Tasks
- T12279: Port frameworks away from QRegExp
- Commits
- R283:b2975d8e630c: Port QRegExp to QRegularExpression
make && ctest
Diff Detail
Diff Detail
- Repository
- R283 KAuth
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| CMakeLists.txt | ||
|---|---|---|
| 14 ↗ | (On Diff #71872) | kauth is a framework package. You can't increase qt version directly. |
| CMakeLists.txt | ||
|---|---|---|
| 14 ↗ | (On Diff #71872) | I didn't know that, sorry. Luckily fixing it is easy in this particular case, I'll anchor the regexp pattern with \A and \z. |
Comment Actions
Don't touch Qt required version directly for frameworks.
Use \A and \z anchors instead of the convenience function QRegularExpression::anchoredPattern()
Comment Actions
This appears to have broken policy file generation. The polkit files I now get have
<description xml:lang="Name[de]">Neues Plymouth-Design installieren</description>
Note the "Name" in the xml:lang
Comment Actions
Right. Should be fixed by D27288. I counted wrongly, QRegExp::capturedTexts(1) is QRegularExpressionMatch::captured(1) not captured(0)...