[KCM/Access] Port to use KConfigXT
AbandonedPublic

Authored by meven on Dec 17 2019, 1:07 PM.

Details

Reviewers
ervin
crossi
Group Reviewers
Plasma
Test Plan

Tested changing settings

Diff Detail

Repository
R119 Plasma Desktop
Branch
kaccess-kconfigxt
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20000
Build 20018: arc lint + arc unit
meven created this revision.Dec 17 2019, 1:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 17 2019, 1:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 17 2019, 1:07 PM
meven updated this revision to Diff 71719.Dec 17 2019, 1:47 PM

Fix some default values

I read kaccess.cpp and commented on where the defaults diverge, there could be more. There's also some keys that have typos and/or don't match.
This shows quite impressively why having this stuff in a central place is useful :)
Given kaccess.cpp is what does the handling, ultimately its defaults will be what is being used, not the ones in the KCM.

kcms/access/kaccess_settings.kcfg
14

lol

Can you give this a better name, like "customBell"

(Arts was the KDE 3 sound server)

18

Likewise, customBellFile

47

"stickied" is not a word but I can see that "stuck" implies something else

56

The default is false

62

"key" or whatever that k stands for?

77

The default is false

81

The default is false

85

The default is false

98

BounceKeysRejectBeep

122

There is only kNotifyAccessX (note the X)

143

This is actually being calculated referencing "interal" in kaccess code:

mouseGroup.readEntry("MKTimeToMax", (5000 + interval / 2) / interval);
145

The key is MKTimeToMax

149

Defaults to interval

156

profil*e*

meven updated this revision to Diff 71734.Dec 17 2019, 4:45 PM
meven marked 12 inline comments as done.

Address review

meven updated this revision to Diff 71756.Dec 18 2019, 8:08 AM

Remove unconvenient white space, add a else to a if block

meven updated this revision to Diff 71757.Dec 18 2019, 8:16 AM

Remove unconvenient white space, add a else to a if block

FYI this KCM is also being rewritten in QML+KConfigXT somewhere else: D25375

meven abandoned this revision.Dec 18 2019, 1:39 PM

FYI this KCM is also being rewritten in QML+KConfigXT somewhere else: D25375

Since the other diff seems quite advanced already I am abandonning this one.

kcms/access/kaccess_settings.kcfg
56

Well no : see defaults() "ui.stickyKeysBeep->setChecked(true);" or load() "keyboardGroup.readEntry("StickyKeysBeep", true)"

77

No see default() " ui.slowKeysPressBeep->setChecked(true);" or load()
The label is contextual.
But slowKeys is by default false making this setting disabled by default still.

81

No ui.slowKeysAcceptBeep->setChecked(true);

85

Same.

98

What do you mean ?
This is the current key of this entry.

122

What do you mean ?

143

Yes and it the default value taking into account the default settings : int((5000 + 5/2) / 5) = 1000

145

No, there are two similar keys MK-TimeToMax and MKTimeToMax, hence your confusion.
I had to replace the "-" with another character to allow to generate function with the name.

Sorry to invalidate your work. :/ Please feel free to review that patch!