- much improves discoverability of the ability to move added widgets without clicking and holding (I have seen people having trouble figuring it out)
- makes it more consistent with panel widget context menus
- allows easier access to the edit mode when the desktop is full of widgets
Details
Details
- Reviewers
mart ngraham davidedmundson - Group Reviewers
Plasma VDG - Commits
- R242:629db2f3b55b: Add edit mode menu item to desktop widget context menu
Open the context menu of a widget on the desktop.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19934 Build 19952: arc lint + arc unit
src/scriptengines/qml/plasmoid/containmentinterface.cpp | ||
---|---|---|
1132 ↗ | (On Diff #71670) | Please check m_containment->immutability() so we don't add this if widgets are locked |
src/scriptengines/qml/plasmoid/containmentinterface.cpp | ||
---|---|---|
1132 ↗ | (On Diff #71670) | Are you sure? It is already automatically disabled when immutability is UserImmutable and completely hidden if SystemImmutable, as it should be (same as for the desktop). |
src/scriptengines/qml/plasmoid/containmentinterface.cpp | ||
---|---|---|
1133 ↗ | (On Diff #71670) | I would prefer to see: auto action = m_containment->corona()->actions()->action(QStringLiteral("edit mode")); if (action) { desktopMenu->addAction(action); } As otherwise we're relying on things which aren't specific public API. It's the sort of thing that can easily change in an updated library release and then our old software starts crashing. |