Replace the default Transmission-Qt icon with a breeze version
Before:
After:
BUG: 414335
Lint Skipped |
Unit Tests Skipped |
Very nice! You even embedded the stylesheet. However there are a number of lines and corners that would look better aligned to grid lines or points. You don't have to always to this, but in general it's better to. Also the Breeze icon style generally has pointy corners rather than rounded ones.
Hey, thanks for the patch!
The actual name of the icon is transmission, so you would have to rename the file to that and add id="transmission" to the group. Since this is a desktop theme icon, you would also have to add an invisible 22x22 rectangle to the group.
However, even after doing all that myself, I can't get this icon to work. I'm not sure why. It doesn't work with transmission-qt either.
Okay, gotcha. I played around a bit but am not too satisfied yet. I tends to look like a grave...
Best I could get yet:
I rebuilt the whole icon taking the SVG of Konversation. Maybe I messed up something with the initial one.
Nope, I even completely redid it and it wouldn't work with transmission or transmission-qt. I don't think this is your fault.
I chceked transmission git code and the icon name it uses is actually transmission-tray-icon, so you want to have a transmission.svg file and the "id" to be transmission-tray-icon, then it should work: https://github.com/transmission/transmission/blob/master/qt/MainWindow.cc#L302
I liked the original design with the trapezoid shape better TBH. The square one does indeed look quite "grave-like"👻👻 and IMO isn't identifiable as Transmission anymore.
Here's one way to make a nice looking trapezoid in the Breeze style. I started by making a stroke with end points in the middle of pixels and the other settings I mentioned in my first comment. Then I converted it to a path and I added a 2px high rectangle to increase the thickness of the bottom part.
Yes. Here's the file if you want it:
We should probably add a 32px version too though. Panel tooltips use 32px icons and I know @ngraham likes to set his systray icons to 32px. 22px icons scaled to 32px usually look blurry.
I ran into another roadblock though. I tried to set the group id to transmission-tray-icon as @broulik said and it still wouldn't work. I wonder if the icon is hardcoded.
wait scratch that, it does work. I had to remove the 22-22- prefix, which is what you normally need when you have multiple icon sizes.
yes, I think I'll move this patch to breeze-icons since there is no longer a name conflict