Details
- Reviewers
davidedmundson - Group Reviewers
VDG Plasma - Commits
- R118:3e0877c9c99d: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2
Diff Detail
- Repository
- R118 Plasma SDK
- Branch
- arcpatch-D25778
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19982 Build 20000: arc lint + arc unit
lookandfeelexplorer/package/contents/ui/main.qml | ||
---|---|---|
46 | This sadly didn't work :( |
lookandfeelexplorer/package/contents/ui/main.qml | ||
---|---|---|
97 | I would do something standardized like largeSpacing. | |
99 | No need to have this IMO. Just put the buttons in the Form Layout and then have them match the fields' width. Normally you would just have them fill the width but because the label above can be long you'd need to assign an id to one of the field and have the buttons's implicitWidth match the width of the field. | |
105 | ("Plugin name: ") | |
166 | "Click to set preview image..." I think it has to be that way because further action is required when clicking. | |
196 | This button need more margins. |
lookandfeelexplorer/package/contents/ui/MetadataEditor.qml | ||
---|---|---|
108 | I tried but I get Type QQC2.ComboBox unavailable 60: StylePrivate.PropertyWriter is not a type |
60: StylePrivate.PropertyWriter is not a type
Sounds like you just had your QQC2 style broken.
In any case, this code all looks fine.
Better to have to port one little combobox in our own time later, than have to deal with regressions.
Thanks for the review :) I will create a follow up patch with the ComboBox port when I figure that is going wrong with my desktop theme.