refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2
ClosedPublic

Authored by ognarb on Dec 6 2019, 3:04 AM.

Diff Detail

Repository
R118 Plasma SDK
Branch
arcpatch-D25778
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19982
Build 20000: arc lint + arc unit
ognarb created this revision.Dec 6 2019, 3:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 6 2019, 3:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Dec 6 2019, 3:04 AM
ognarb edited the summary of this revision. (Show Details)Dec 6 2019, 3:05 AM
ognarb edited the test plan for this revision. (Show Details)
ognarb added reviewers: VDG, Plasma.
ognarb added inline comments.Dec 6 2019, 3:10 AM
lookandfeelexplorer/package/contents/ui/main.qml
46

This sadly didn't work :(

If your use as QQC2 in your imports, ComboBox need to be changed to QQC2.ComboBox.

lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
108

This need to be changed to QQC2.ComboBox

lookandfeelexplorer/package/contents/ui/main.qml
49

This need to be changed to QQC2.ComboBox

filipf added a subscriber: filipf.Dec 6 2019, 10:44 AM
filipf added inline comments.
lookandfeelexplorer/package/contents/ui/main.qml
97

I would do something standardized like largeSpacing.

99

No need to have this IMO.

Just put the buttons in the Form Layout and then have them match the fields' width.

Normally you would just have them fill the width but because the label above can be long you'd need to assign an id to one of the field and have the buttons's implicitWidth match the width of the field.

105

("Plugin name: ")

166

"Click to set preview image..."

I think it has to be that way because further action is required when clicking.

196

This button need more margins.

ognarb updated this revision to Diff 71732.Dec 17 2019, 4:20 PM
ognarb marked 2 inline comments as done.
  • Use same button width as for the text field
  • Fix dialog not closing
  • Improve margin
ognarb updated this revision to Diff 71733.Dec 17 2019, 4:21 PM
ognarb marked 2 inline comments as done.
  • fix naming
ognarb added inline comments.Dec 17 2019, 4:21 PM
lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
108

I tried but I get

Type QQC2.ComboBox unavailable
60: StylePrivate.PropertyWriter is not a type
ognarb edited the test plan for this revision. (Show Details)Dec 17 2019, 4:21 PM
davidedmundson accepted this revision.Dec 17 2019, 5:57 PM
davidedmundson added a subscriber: davidedmundson.

60: StylePrivate.PropertyWriter is not a type

Sounds like you just had your QQC2 style broken.

In any case, this code all looks fine.
Better to have to port one little combobox in our own time later, than have to deal with regressions.

This revision is now accepted and ready to land.Dec 17 2019, 5:57 PM
ognarb retitled this revision from refactor(lookandfeelexplorer): Port mostly to QQC2 to refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2.Dec 17 2019, 6:13 PM
ognarb edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.

Thanks for the review :) I will create a follow up patch with the ComboBox port when I figure that is going wrong with my desktop theme.