[FolderView] Base decision on effectiveLayoutDirection instead of layoutDirection
ClosedPublic

Authored by broulik on Aug 22 2016, 7:46 PM.

Details

Summary

The code in many places already tried to take care of right-to-left layout but it was operating on layoutDirection which never actually changes if the layout is mirrored. "effectiveLayoutDirection" tells you what the actual direction is.

Test Plan

Enabled LayoutMirroring on the desktop containment and:

  • Rubber band selection now selects the correct files (rather than their mirrored counterparts)
  • Dragging and dropping files drops them at the right place (rather than the opposite corner)
  • Keyboard nav left actually moves selection left instead of right

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6157.Aug 22 2016, 7:46 PM
broulik retitled this revision from to [FolderView] Base decision on effectiveLayoutDirection instead of layoutDirection.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, safaalfulaij, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 22 2016, 7:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 22 2016, 7:52 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 22 2016, 7:52 PM
This revision was automatically updated to reflect the committed changes.