Differential D2539

[Desktop Containment] Enable LayoutMirroring
ClosedPublic
Actions

Authored by broulik on Aug 22 2016, 7:54 PM.

Details

Reviewers
davidedmundson
safaalfulaij
Group Reviewers
Plasma
Commits
R119:cde7ee6dd268: [Desktop Containment] Enable LayoutMirroring
Summary

This mirrors all the applet contents as well as the applet handle whose translation is adjusted.

Test Plan
  • Analog clock still looks as in left-to-right (dunno how clocks in right-to-left languages look, though)
  • Sticky notes applet had its controls mirrored as expected
  • FolderView needs some fixing (see D2538), some more fixes (eg. popup dialog) will arrive shortly
  • Color picker had its two buttons mirrored (popups already auto-mirror for some time)

Tested resizing applets in both normal and reverse mode, resizing honors minimum size and looks fine.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6160.Aug 22 2016, 7:54 PM
broulik retitled this revision from to WIP: [Desktop Containment] Enable LayoutMirroring.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, safaalfulaij.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 22 2016, 7:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
safaalfulaij edited edge metadata.Aug 22 2016, 7:57 PM

Analog clock still looks as in left-to-right (dunno how clocks in right-to-left languages look, though)

xD Not for the clock :)

davidedmundson accepted this revision.Sep 9 2016, 11:23 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Sep 9 2016, 11:23 AM
broulik updated this revision to Diff 6589.Sep 9 2016, 12:15 PM
broulik retitled this revision from WIP: [Desktop Containment] Enable LayoutMirroring to [Desktop Containment] Enable LayoutMirroring.
broulik edited the test plan for this revision. (Show Details)
broulik edited edge metadata.
Closed by commit R119:cde7ee6dd268: [Desktop Containment] Enable LayoutMirroring (authored by broulik). · Explain WhySep 9 2016, 12:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6593

View Options

containments/desktop/package/contents/ui/AppletHandle.qml

Loading...
View Options

containments/desktop/package/contents/ui/main.qml

Loading...