Differential D25333

scripty: Look for helper scripts in the current script's parent directory
AbandonedPublic
Actions

Authored by aspotashev on Nov 16 2019, 5:58 AM.

Details

Reviewers

pino

Group Reviewers

Localization

Maniphest Tasks

T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository

Summary

Should allow us to move update_translations and its helper scripts to another directory.

Test Plan

Partially tested locally.

After this is merged and Scripty nightly run is complete, we should check the logs at https://logs.l10n.kde.org/ for potential errors.

Diff Detail

Repository

R883 Subversion

Lint

Lint Skipped

Unit

Unit Tests Skipped

aspotashev requested review of this revision.Nov 16 2019, 5:58 AM

aspotashev created this revision.

There is still a problem with referencing the subdirs file from non-standard directories. I will fix that in another iteration because SVN reviews are nightmare, let me merge this one first.

I think we.may.want to.move scripty to git first and start using proper branches, maybe unifying at least the various kf5 code. @nalvarez, did yiu have some time to look at T4803?

aspotashev mentioned this in T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.Nov 16 2019, 4:57 PM

I would like to merge this before migrating to Git to minimize the transition period, see https://phabricator.kde.org/T4803#208462

I disagree with this approach (see the other task).

In D25333#563202, @ltoscano wrote:

I think we.may.want to.move scripty to git first and start using proper branches, maybe unifying at least the various kf5 code. @nalvarez, did yiu have some time to look at T4803?

Migration to git is still not moving forward. Can I please commit this patch to SVN?

It only means that we need to plan the migration ourselves.

aspotashev added a task: T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.Dec 8 2019, 2:21 PM

There are various issues here:

we are touching even branches that are dead or in maintenance mode, which means an high risk of issues
the same 4 lines of patterns is repeated over and over
the way to get the directory of a script is overly verbose, using realpath is way easier/faster...

Even considered the above, what is the actual use case for these intrusive changes?
All the scripts assume that there is a structure like:

l10n
- templates
- scripts
- lang1
- lang2
- langN

so even if scripts is moved away from SVN, the simple way to move this work again is to symlink the directory with the scripts as new scripts subdirectory.

This revision now requires changes to proceed.Dec 8 2019, 4:48 PM

Roughly the same was done in https://invent.kde.org/sysadmin/l10n-scripty/-/commit/6bad01a4aea8cb4c43ba57a904c1c882ebc4fbe9 , abandoning this patch.

Revision Contents
Changeset List

			Path	Packages
M			branches/stable/l10n-kde4/scripts/check_po_files (9 lines)
M			branches/stable/l10n-kde4/scripts/checkdocs.sh (13 lines)
M			branches/stable/l10n-kde4/scripts/createdoctemplates.sh (13 lines)
M			branches/stable/l10n-kde4/scripts/find_meinproc (7 lines)
M			branches/stable/l10n-kde4/scripts/findfiles (11 lines)
M			branches/stable/l10n-kde4/scripts/merge_desktop_files.sh (7 lines)
M			branches/stable/l10n-kde4/scripts/populate_documentation.sh (13 lines)
M			branches/stable/l10n-kde4/scripts/populate_source.sh (13 lines)
M			branches/stable/l10n-kde4/scripts/posieve_check-tp-kde_results_to_webpage.sh (11 lines)
M			branches/stable/l10n-kde4/scripts/update_translations (38 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/check_po_files (9 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/checkdocs.sh (13 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/create_desktop_files.sh (12 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/createdoctemplates.sh (13 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/extract-tr-strings (4 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/find_meinproc (7 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/findfiles (11 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/handle_json_files.sh (9 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/merge_desktop_files.sh (7 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/populate_documentation.sh (13 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/populate_source.sh (13 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/posieve_check-tp-kde_results_to_webpage.sh (11 lines)
M			branches/stable/l10n-kf5-plasma-lts/scripts/update_translations (40 lines)
M			branches/stable/l10n-kf5/scripts/check_po_files (9 lines)
M			branches/stable/l10n-kf5/scripts/checkdocs.sh (13 lines)
M			branches/stable/l10n-kf5/scripts/create_desktop_files.sh (12 lines)
M			branches/stable/l10n-kf5/scripts/createdoctemplates.sh (13 lines)
M			branches/stable/l10n-kf5/scripts/extract-tr-strings (4 lines)
M			branches/stable/l10n-kf5/scripts/find_meinproc (7 lines)
M			branches/stable/l10n-kf5/scripts/findfiles (11 lines)
M			branches/stable/l10n-kf5/scripts/handle_json_files.sh (9 lines)
M			branches/stable/l10n-kf5/scripts/merge_desktop_files.sh (7 lines)
M			branches/stable/l10n-kf5/scripts/populate_documentation.sh (13 lines)
M			branches/stable/l10n-kf5/scripts/populate_source.sh (13 lines)
M			branches/stable/l10n-kf5/scripts/posieve_check-tp-kde_results_to_webpage.sh (11 lines)
M			branches/stable/l10n-kf5/scripts/update_translations (40 lines)
M			trunk/l10n-kde4/scripts/check_po_files (9 lines)
M			trunk/l10n-kde4/scripts/checkdocs.sh (13 lines)
M			trunk/l10n-kde4/scripts/createdoctemplates.sh (13 lines)
M			trunk/l10n-kde4/scripts/find_meinproc (7 lines)
M			trunk/l10n-kde4/scripts/findfiles (11 lines)
M			trunk/l10n-kde4/scripts/merge_desktop_files.sh (7 lines)
M			trunk/l10n-kde4/scripts/populate_documentation.sh (13 lines)
M			trunk/l10n-kde4/scripts/populate_source.sh (13 lines)
M			trunk/l10n-kde4/scripts/posieve_check-tp-kde_results_to_webpage.sh (11 lines)
M			trunk/l10n-kde4/scripts/update_translations (38 lines)
M			trunk/l10n-kf5/scripts/check_po_files (9 lines)
M			trunk/l10n-kf5/scripts/checkdocs.sh (13 lines)
M			trunk/l10n-kf5/scripts/create_desktop_files.sh (12 lines)
M			trunk/l10n-kf5/scripts/createdoctemplates.sh (13 lines)
M			trunk/l10n-kf5/scripts/extract-tr-strings (4 lines)
M			trunk/l10n-kf5/scripts/find_meinproc (7 lines)
M			trunk/l10n-kf5/scripts/findfiles (11 lines)
M			trunk/l10n-kf5/scripts/handle_json_files.sh (9 lines)
M			trunk/l10n-kf5/scripts/merge_desktop_files.sh (7 lines)
M			trunk/l10n-kf5/scripts/populate_documentation.sh (13 lines)
M			trunk/l10n-kf5/scripts/populate_source.sh (13 lines)
M			trunk/l10n-kf5/scripts/posieve_check-tp-kde_results_to_webpage.sh (11 lines)
M			trunk/l10n-kf5/scripts/update_translations (46 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69828			Nov 16 2019, 5:40 AM	★	★

scripty: Look for helper scripts in the current script's parent directoryAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 69828

branches/stable/l10n-kde4/scripts/check_po_files

branches/stable/l10n-kde4/scripts/checkdocs.sh

branches/stable/l10n-kde4/scripts/createdoctemplates.sh

branches/stable/l10n-kde4/scripts/find_meinproc

branches/stable/l10n-kde4/scripts/findfiles

branches/stable/l10n-kde4/scripts/merge_desktop_files.sh

branches/stable/l10n-kde4/scripts/populate_documentation.sh

branches/stable/l10n-kde4/scripts/populate_source.sh

branches/stable/l10n-kde4/scripts/posieve_check-tp-kde_results_to_webpage.sh

branches/stable/l10n-kde4/scripts/update_translations

branches/stable/l10n-kf5-plasma-lts/scripts/check_po_files

branches/stable/l10n-kf5-plasma-lts/scripts/checkdocs.sh

branches/stable/l10n-kf5-plasma-lts/scripts/create_desktop_files.sh

branches/stable/l10n-kf5-plasma-lts/scripts/createdoctemplates.sh

branches/stable/l10n-kf5-plasma-lts/scripts/extract-tr-strings

branches/stable/l10n-kf5-plasma-lts/scripts/find_meinproc

branches/stable/l10n-kf5-plasma-lts/scripts/findfiles

branches/stable/l10n-kf5-plasma-lts/scripts/handle_json_files.sh

branches/stable/l10n-kf5-plasma-lts/scripts/merge_desktop_files.sh

branches/stable/l10n-kf5-plasma-lts/scripts/populate_documentation.sh

branches/stable/l10n-kf5-plasma-lts/scripts/populate_source.sh

branches/stable/l10n-kf5-plasma-lts/scripts/posieve_check-tp-kde_results_to_webpage.sh

branches/stable/l10n-kf5-plasma-lts/scripts/update_translations

branches/stable/l10n-kf5/scripts/check_po_files

branches/stable/l10n-kf5/scripts/checkdocs.sh

branches/stable/l10n-kf5/scripts/create_desktop_files.sh

branches/stable/l10n-kf5/scripts/createdoctemplates.sh

branches/stable/l10n-kf5/scripts/extract-tr-strings

branches/stable/l10n-kf5/scripts/find_meinproc

branches/stable/l10n-kf5/scripts/findfiles

branches/stable/l10n-kf5/scripts/handle_json_files.sh

branches/stable/l10n-kf5/scripts/merge_desktop_files.sh

branches/stable/l10n-kf5/scripts/populate_documentation.sh

branches/stable/l10n-kf5/scripts/populate_source.sh

branches/stable/l10n-kf5/scripts/posieve_check-tp-kde_results_to_webpage.sh

branches/stable/l10n-kf5/scripts/update_translations

trunk/l10n-kde4/scripts/check_po_files

trunk/l10n-kde4/scripts/checkdocs.sh

trunk/l10n-kde4/scripts/createdoctemplates.sh

trunk/l10n-kde4/scripts/find_meinproc

trunk/l10n-kde4/scripts/findfiles

trunk/l10n-kde4/scripts/merge_desktop_files.sh

trunk/l10n-kde4/scripts/populate_documentation.sh

trunk/l10n-kde4/scripts/populate_source.sh

trunk/l10n-kde4/scripts/posieve_check-tp-kde_results_to_webpage.sh

trunk/l10n-kde4/scripts/update_translations

trunk/l10n-kf5/scripts/check_po_files

trunk/l10n-kf5/scripts/checkdocs.sh

trunk/l10n-kf5/scripts/create_desktop_files.sh

trunk/l10n-kf5/scripts/createdoctemplates.sh

trunk/l10n-kf5/scripts/extract-tr-strings

trunk/l10n-kf5/scripts/find_meinproc

trunk/l10n-kf5/scripts/findfiles

trunk/l10n-kf5/scripts/handle_json_files.sh

trunk/l10n-kf5/scripts/merge_desktop_files.sh

trunk/l10n-kf5/scripts/populate_documentation.sh

trunk/l10n-kf5/scripts/populate_source.sh

trunk/l10n-kf5/scripts/posieve_check-tp-kde_results_to_webpage.sh

trunk/l10n-kf5/scripts/update_translations

scripty: Look for helper scripts in the current script's parent directory
AbandonedPublic
Actions

Revision Contents
Changeset List