Differential D25270

Correctly set i18n arguments in one pass
ClosedPublic
Actions

Authored by davidedmundson on Nov 12 2019, 11:58 AM.

Details

Reviewers
leinir
apol
Commits
R304:0099d090be51: Correctly set i18n arguments in one pass
Summary

i18n("asdf %1") will expand and fail as it has no arguments, leading to
a warning.

BUG: 414060

Diff Detail

Repository
R304 KNewStuff
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18711
Build 18729: arc lint + arc unit
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 12 2019, 11:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 12 2019, 11:58 AM
apol accepted this revision.Nov 15 2019, 3:31 PM
This revision is now accepted and ready to land.Nov 15 2019, 3:31 PM
Closed by commit R304:0099d090be51: Correctly set i18n arguments in one pass (authored by davidedmundson). · Explain WhyNov 15 2019, 3:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qtquick/qml/Button.qml (2 lines)

Diff 69630

View Options

src/qtquick/qml/Button.qml

Loading...