Fixing ASTAP Path on OS X and Setting Autostar as default for PHD2 Guiding
Summary:
- Fixing the default path for ASTAP on os x.
- Clearing the tracking box after a meridian flip because the guide star is no longer valid
- Moving the Meridian flip code that affects guiding to the guider where it makes more sense.
The changes were necessary because users reported that when using Ekos remotely controlling PHD2, but not using the autostar option,
after a meridian flip, the previously selected lock position is of course no longer valid, but Ekos still tries to make it use the previously selected star which moved.
So rather than trying to calculate the new star position based on a previously selected guide star, I believe it is better to clear the selected guide star.
Test Plan:
Please test to make sure that this code does not cause any issue with doing the meridian flip whether the user is using PHD2 or the internal guider. Guiding should still start back up automatically as it did before.
And test that after a meridian flip when using PHD2, whether the user was using auto-star or not using auto-star, lock position that was previously selected is not selected any more.
This should now work for the internal guider as well.
Reviewers: mutlaqja, wreissenberger
Reviewed By: mutlaqja, wreissenberger
Subscribers: wreissenberger, murveit, kde-edu
Tags: KDE Edu
Differential Revision: https://phabricator.kde.org/D25060