Now that KCModule exposes a defaulted() signal, consume it and keep our
own defaulted state up to date. This is exposed for further consumption
in the GUIs integrating KCModuleProxy.
This depends on: https://phabricator.kde.org/D25069
Details
Details
- Reviewers
mart davidedmundson dfaure - Group Reviewers
Plasma Frameworks - Commits
- R295:dc836403bb5d: Have KCModuleProxy take care of the defaulted state
Diff Detail
Diff Detail
- Repository
- R295 KCMUtils
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/kcmoduleproxy.cpp | ||
|---|---|---|
| 196–197 | Why emit changed? Given KCModuleProxy mirrors KCModule API I would have expected a defaulted signal to match? | |
| src/kcmoduleproxy.cpp | ||
|---|---|---|
| 196–197 | Because all the consumers I found surprisingly don't care about the distinction or the value of that bool. Also it would have led to more intrusive changes in said consumers. I admit I was surprised about that. | |
Comment Actions
Edit: ah, I see why.
KCMMultiDialog and system settings re-evaluate the buttons on receipt of the changed signal
Still seems maybe a bit odd, but it makes sense in context.
Comment Actions
I don't disagree, it makes it look odd. I just didn't feel going for the even more intrusive route, I touched quite a few moving pieces already.