Adjust KCModule to also channel information about defaults
ClosedPublic

Authored by ervin on Oct 30 2019, 10:58 AM.

Details

Summary

We'd probably do things differently nowadays (including the signal
name...) but I tried to stay as close as possible to KCModule current
structure.

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Oct 30 2019, 10:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 30 2019, 10:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ervin requested review of this revision.Oct 30 2019, 10:58 AM
davidedmundson accepted this revision.Oct 30 2019, 12:13 PM

One minor change

src/kcmodule.cpp
201

this line becomes redundant as widgetChanged() will always emit it

This revision is now accepted and ready to land.Oct 30 2019, 12:13 PM
ervin marked an inline comment as done.Oct 30 2019, 12:23 PM
ervin updated this revision to Diff 69269.Nov 4 2019, 1:55 PM

Add missing @since markers

This revision was automatically updated to reflect the committed changes.