Differential D25057

Get rid of search "More Options" toggle button
ClosedPublic
Actions

Authored by iasensio on Oct 29 2019, 7:57 PM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
VDG
Commits
R318:54bd267eb96d: Get rid of search "More Options" toggle button
Summary

With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages).
These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled.
For some nicer aesthetics D25029 should be also applied.

CCBUG: 386754

Test Plan

Current:


After:

Along with D25029:

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Oct 29 2019, 7:57 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 29 2019, 7:57 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 29 2019, 7:57 PM
iasensio edited the summary of this revision. (Show Details)Oct 29 2019, 7:59 PM
iasensio edited the test plan for this revision. (Show Details)
ngraham accepted this revision as: VDG, ngraham.Oct 29 2019, 9:10 PM
This revision is now accepted and ready to land.Oct 29 2019, 9:10 PM
elvisangelaccio added a comment.Nov 2 2019, 12:00 PM

Patch looks good, but I don't see how we fix https://bugs.kde.org/show_bug.cgi?id=386754

"More Search Tools" still gets hidden if dolphin is not wide enough, as reported in that bug.

iasensio added a comment.Nov 2 2019, 8:02 PM

You're right. It just helps reducing the 'wide enough' a bit. I'll CC the bug instead.

iasensio edited the summary of this revision. (Show Details)Nov 2 2019, 8:03 PM
elvisangelaccio accepted this revision.Nov 3 2019, 10:04 PM
Closed by commit R318:54bd267eb96d: Get rid of search "More Options" toggle button (authored by iasensio, committed by elvisangelaccio). · Explain WhyNov 3 2019, 10:04 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Nov 3 2019, 10:06 PM

@iasensio Please consider applying for a developer account ;)

See https://community.kde.org/Infrastructure/Get_a_Developer_Account for instructions.

iasensio added a comment.Nov 5 2019, 4:39 PM
In D25057#558279, @elvisangelaccio wrote:

@iasensio Please consider applying for a developer account ;)

See https://community.kde.org/Infrastructure/Get_a_Developer_Account for instructions.

Application is on the go. Thanks! 😃

Revision Contents
Changeset List

Diff 69237

View Options

src/search/dolphin_searchsettings.kcfg

Loading...
View Options

src/search/dolphinsearchbox.h

Loading...
View Options

src/search/dolphinsearchbox.cpp

Loading...