This patch add a No/100 to the text when a check has not fratcoinal part Also it captalizes the first letter to all on the number in text to be printed.
AcceptedPublic

Authored by philhopkins on Tue, Oct 29, 3:20 AM.

Details

Reviewers
tbaumgart
Group Reviewers
KMyMoney
Summary

It goes with KDE bug 412513

Captalizes the first letter for each number to be printed in text and for checks that have no fractional part prints No/100

Diff Detail

Repository
R261 KMyMoney
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18293
Build 18311: arc lint + arc unit
philhopkins requested review of this revision.Tue, Oct 29, 3:20 AM
philhopkins created this revision.
philhopkins edited the summary of this revision. (Show Details)Tue, Oct 29, 3:25 AM
philhopkins added a reviewer: KMyMoney.
tbaumgart accepted this revision as: tbaumgart.Fri, Nov 1, 2:12 PM
tbaumgart added a subscriber: tbaumgart.

Looks good to me. I have to admit that the whole logic seems very English centric and would not really apply well to a German or French translation from what I see. E.g. 92 in French translates to 80+12 and in German 92 translates to 2 and 90.

This revision is now accepted and ready to land.Fri, Nov 1, 2:12 PM

I just filed a wishlist (Bug 413713) to make the number to text conversion language specific. I also wonder if Bug 255492 (KMyMomney's currency system should be ported to use KDE currency support) might be relevant to this issue.