This patch add a No/100 to the text when a check has not fratcoinal part Also it captalizes the first letter to all on the number in text to be printed.
ClosedPublic
Actions

Authored by philhopkins on Oct 29 2019, 3:20 AM.

Details

Reviewers

Group Reviewers

Commits

R261:2741bd698449: Add a No/100 to the text when a check has not fractional part
R261:adf36334ac97: Add a No/100 to the text when a check has not fractional part

Summary

It goes with KDE bug 412513

Captalizes the first letter for each number to be printed in text and for checks that have no fractional part prints No/100

Diff Detail

Repository

R261 KMyMoney

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18293
Build 18311: arc lint + arc unit

philhopkins requested review of this revision.Oct 29 2019, 3:20 AM

philhopkins created this revision.

Harbormaster completed remote builds in B18293: Diff 68938.Oct 29 2019, 3:20 AM

philhopkins edited the summary of this revision. (Show Details)Oct 29 2019, 3:25 AM

philhopkins added a reviewer: KMyMoney.

iasensio mentioned this in D25057: Get rid of search "More Options" toggle button.Oct 29 2019, 7:57 PM

Looks good to me. I have to admit that the whole logic seems very English centric and would not really apply well to a German or French translation from what I see. E.g. 92 in French translates to 80+12 and in German 92 translates to 2 and 90.

This revision is now accepted and ready to land.Nov 1 2019, 2:12 PM

I just filed a wishlist (Bug 413713) to make the number to text conversion language specific. I also wonder if Bug 255492 (KMyMomney's currency system should be ported to use KDE currency support) might be relevant to this issue.

elvisangelaccio mentioned this in R318:54bd267eb96d: Get rid of search "More Options" toggle button.Nov 3 2019, 10:04 PM

Closed by commit R261:2741bd698449: Add a No/100 to the text when a check has not fractional part (authored by tbaumgart). · Explain WhyJan 30 2020, 9:04 PM

This revision was automatically updated to reflect the committed changes.

Just out of curiosity, is the No/100 translatable in cases where the local currency is not usually reported to two decimal places?

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/plugins/checkprinting/numbertowords.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68938	bdf2ef4		Oct 29 2019, 3:20 AM	★	★
Diff 2	74730	98ac8a2	R261:2741bd69844973b387bfe9b405e3a764819ef2ef	Jan 30 2020, 9:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a0fc2f936e43	35f9fd83eb80	bdf2ef4b5c67	Phil Hopkins	This patch add a No/100 to the text when a check has not fratcoinal part Also… (Show More…)	Oct 29 2019, 3:20 AM

Diff 68938

View Options

kmymoney/plugins/checkprinting/numbertowords.cpp