Differential D24978

Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut
AbandonedPublic
Actions

Authored by meven on Oct 27 2019, 8:47 AM.

Details

Reviewers
davidre
fvogt
apol
Group Reviewers
Plasma
Summary

Currently KglobalAccel uses NoDisplay to disable its component.
But NoDisplay is to be used for hiding programs in menus.
This keeps program whose desktop file are not displayed in Menu to have shortcuts.
Ex: krunner D24857

Add a key "X-KDE-NoGlobalShortcut" specific for use in KglobalAccel and its kcm.

Relates to D24956

Diff Detail

Repository
R309 KService
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18212
Build 18230: arc lint + arc unit
meven created this revision.Oct 27 2019, 8:47 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 27 2019, 8:47 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Oct 27 2019, 8:47 AM
apol added a comment.Oct 28 2019, 11:40 AM

This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property?

src/services/kservice.cpp
739

return qvariant_cast<bool>(property(QStringLiteral("X-KDE-NoGlobalShortcut"), QVariant::Bool));

meven abandoned this revision.Oct 28 2019, 12:38 PM
In D24978#555165, @apol wrote:

This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property?

I agree, I didn't find property when I looked at KService in the first place, thanks.

Abandonning

Revision Contents
Changeset List

PathPackages
Msrc/services/kservice.h (6 lines)
Msrc/services/kservice.cpp (9 lines)

Diff 68814

View Options

src/services/kservice.h

Loading...
View Options

src/services/kservice.cpp

Loading...