Install krunner desktop file to ${KDE_INSTALL_APPDIR}
AcceptedPublic

Authored by meven on Oct 25 2019, 3:36 PM.

Details

Reviewers
fvogt
apol
Group Reviewers
Plasma
Summary

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18173
Build 18191: arc lint + arc unit
meven created this revision.Oct 25 2019, 3:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 25 2019, 3:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Oct 25 2019, 3:36 PM
fvogt accepted this revision.EditedOct 25 2019, 3:42 PM

IMO it's a good thing to have KRunner as application in the menu anyway

This revision is now accepted and ready to land.Oct 25 2019, 3:42 PM
meven added a comment.Oct 25 2019, 3:54 PM

IMO it's a good thing to have KRunner as application in the menu anyway

It was not in the application menu before
With this change (and without NoDisplay) it will be displayed.

So I really think we should change kglobalaccel behavior ignoring application with NoDisplay like it should.

NoDisplay means "this application exists, but don't display it in the menus". This can be useful to e.g. associate this application with MIME types, so that it gets launched from a file manager (or other apps), without having a menu entry for it (there are tons of good reasons for this, including e.g. the netscape -remote, or kfmclient openURL kind of stuff). "

https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

fvogt added a comment.Oct 25 2019, 4:15 PM

IMO it's a good thing to have KRunner as application in the menu anyway

It was not in the application menu before
With this change (and without NoDisplay) it will be displayed.

IMO an improvement.

So I really think we should change kglobalaccel behavior ignoring application with NoDisplay like it should.

Yup, it should read Hidden instead.

ngraham added a subscriber: ngraham.Dec 5 2019, 8:53 PM

What's the status of this patch?

meven added a comment.Dec 8 2019, 7:10 PM

Somewhat depends on D25089 and D25088