Revert "Install krunner desktop file to ${KDE_INSTALL_APPDIR}"

Authored by fvogt on Oct 25 2019, 2:37 PM.

Description

Revert "Install krunner desktop file to ${KDE_INSTALL_APPDIR}"

This reverts commit b3065f7db0d6e94cff0ee5d385ce32bef1779794.

kglobalaccel honours NoDisplay=true, leading to krunner.desktop getting
ignored completely.

CCMAIL: meven29@gmail.com

Details

meven added a subscriber: meven.Oct 25 2019, 3:38 PM

kglobalaccel honours NoDisplay=true, leading to krunner.desktop getting ignored completely.

Then the bug is in kglobalaccel wrongly interpreting NoDisplay, the spec says :

NoDisplay means "this application exists, but don't display it in the menus". This can be useful to e.g. associate this application with MIME types, so that it gets launched from a file manager (or other apps), without having a menu entry for it (there are tons of good reasons for this, including e.g. the netscape -remote, or kfmclient openURL kind of stuff). "

https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

The example here with mimetype would stand the same for shortcuts.

In the meantime : D24947

apol accepted this commit.Oct 25 2019, 3:42 PM
apol added a subscriber: apol.

I don't understand why it was reverted instead of addressed.

All concerns with this commit have now been addressed.Oct 25 2019, 3:42 PM