[RFC] Drop implicit size from PC buttons
AbandonedPublic

Authored by ngraham on Oct 23 2019, 8:13 PM.

Details

Reviewers
mart
davidedmundson
nicolasfella
Group Reviewers
Plasma
VDG
Summary

It makes buttons in apps using plasma as a QQC2 style weirdly wide.

A comment suggests that this is intentional for compatibility reasons. @mart can you please expand on why this was necessary and whether it still is?

A workaround for applications for this issue would be to set an explicit implicit size (heh), but doing that /everywhere/ souds wrong to me

Test Plan

QT_QUICK_CONTROLS_STYLE=plasma kdeconnect-app

Before, note the button in the top left

After:

Saw no visual regression in the few plasmoids I use

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
mo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18084
Build 18102: arc lint + arc unit
nicolasfella created this revision.Oct 23 2019, 8:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 23 2019, 8:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Oct 23 2019, 8:13 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 23 2019, 8:15 PM
  • Actually remove
ngraham added a reviewer: VDG.Oct 23 2019, 9:06 PM
ngraham added a subscriber: ngraham.

Compatibility with the wide style in PC1 I think? I've always thought this was kind of weird as well.

Perhaps only when it has no text so icon-only can become rightfully square?

Please run plasma tests/components/button.qml and tests/components/button3.qml it explains all goals visually (and shows some other PC3 issues)

This patch fails "button with or without icon and textfield should all have the same height"

I understand why you want to change the width, we used to have a special property on the PC2 version that allowed for what you want.

Having had a play, setting implicitWidth to unit.gridUnit * 1.6
and keeping height as-is, makes the most things pass.

davidedmundson requested changes to this revision.Mar 20 2020, 9:54 AM

Marking as request changes as per my comments above

This revision now requires changes to proceed.Mar 20 2020, 9:54 AM
ngraham abandoned this revision.Jul 29 2020, 7:44 PM