Similar to XDG_DATA_DIRS defaulting to KDE_INSTALL_FULL_DATAROOTDIR, and
some sensible constants, also make XDG_CONFIG_DIRS default to KDE_INSTALL_FULL_CONFDIR
and some sensible constants.
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18153 Build 18171: arc lint + arc unit
Comment Actions
Bug in the commit log: s/ also make XDG_DATA_DIRS/ also make XDG_CONFIG_DIRS/
| startkde/startplasma.cpp | ||
|---|---|---|
| 195 | I see nothing FreeBSD specific about this, I suggest simplifying the comment. | |
Comment Actions
Please make sure the first line of the commit log says CONFIG and not DATA, too (the phab title still says DATA).
| startkde/startplasma.cpp | ||
|---|---|---|
| 197 | Wait, where does /usr/local/etc/xdg come from? https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html says the default is only /etc/xdg. | |
| startkde/startplasma.cpp | ||
|---|---|---|
| 197 | On FreeBSD (other BSD's, too), /etc is for the base system only, and all user-add-ons go in *$LOCALBASE*, usually /usr/local .. so XDG stuff, which is a user-add-on, goes into /usr/local/etc. Even our /etc/os-release is in /usr/local/etc/os-release (and Frameworks are suitably patched for that). Some BSD derivatives are less dogmatic about /etc, but not us. | |
Comment Actions
Calling @davidedmundson .. I would migrate this to invent, except in 3c1a34a26dbdf7c123782746881d914cd47b27b6 the similar adjustment for XDG_DATA_DIRS was already removed. We carry this patch, but recent Plasma's no longer set XDG_DATA dir so I think your call on the variable (noone relies on it) is the right one and this can be abandoned.