Revert change to make the notification persistent

Authored by ngraham on Oct 18 2019, 8:50 PM.



Nobody liked it and it was annoying. From a conceptual standpoint, it was redundant
anyway because the SNI in the system tray is already persistent when there's an update

Targeting 5.17.1 for this.

Test Plan

Restart plasmashell, see that the "updates available" notification disappears after a few seconds

Diff Detail

R134 Discover Software Store
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 18 2019, 8:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2019, 8:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 18 2019, 8:50 PM
apol added a comment.Oct 18 2019, 8:57 PM

Other than that, LGTM


I wouldn't remove these. It's good that it reacts to opening Discover. It shows that it's connected.

ngraham updated this revision to Diff 68265.Oct 18 2019, 9:01 PM
ngraham marked an inline comment as done.

Don't stop keeping track of the notification, so we can still close it when Discover is launched

That pares down the diff quite a bit. :)

apol accepted this revision.Oct 18 2019, 9:04 PM


This revision is now accepted and ready to land.Oct 18 2019, 9:04 PM

I had a feeling this would be popular. :)

This revision was automatically updated to reflect the committed changes.