Differential D24766

Revert change to make the notification persistent
ClosedPublic
Actions

Authored by ngraham on Oct 18 2019, 8:50 PM.

Details

Reviewers
apol
broulik
Group Reviewers
Discover Software Store
Commits
R134:d9db05ddef96: Revert change to make the notification persistent
Summary

Nobody liked it and it was annoying. From a conceptual standpoint, it was redundant
anyway because the SNI in the system tray is already persistent when there's an update
available.

Targeting 5.17.1 for this.

Test Plan

Restart plasmashell, see that the "updates available" notification disappears after a few seconds

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 18 2019, 8:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2019, 8:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 18 2019, 8:50 PM
apol added a comment.Oct 18 2019, 8:57 PM

Other than that, LGTM

notifier/DiscoverNotifier.cpp
67

I wouldn't remove these. It's good that it reacts to opening Discover. It shows that it's connected.

ngraham updated this revision to Diff 68265.Oct 18 2019, 9:01 PM
ngraham marked an inline comment as done.

Don't stop keeping track of the notification, so we can still close it when Discover is launched

ngraham added a comment.Oct 18 2019, 9:02 PM

That pares down the diff quite a bit. :)

apol accepted this revision.Oct 18 2019, 9:04 PM

😁

This revision is now accepted and ready to land.Oct 18 2019, 9:04 PM
ngraham added a comment.Oct 18 2019, 9:05 PM

I had a feeling this would be popular. :)

Closed by commit R134:d9db05ddef96: Revert change to make the notification persistent (authored by ngraham). · Explain WhyOct 18 2019, 9:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mnotifier/DiscoverNotifier.cpp (2 lines)

Diff 68266

View Options

notifier/DiscoverNotifier.cpp

Loading...