This is needed as part of porting Koversation to use QSslSocket instead
of KTcpSocket.
Details
The code compiles
Diff Detail
- Repository
- R241 KIO
- Branch
- ahmad/ktcpsocket-qsslsocket (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17605 Build 17623: arc lint + arc unit
My reasoning is, konversation only needs to know about SslUi::askIgnoreSslErrors and not KSslErrorUiData (implementation detail in SslUi). It's more "streamlined" for users of askIgnoreSslErrors to pass it an SSL socket rather than a KSslErrorUiData object. Anyway, I don't mind either way.
That would be my gut feeling as well, ie. have sslui depend on the abstract error representation, not on all possible error sources. OTOH it's not changing the dependency situation overall here so no strong objection to that either. In any case the KTcpSocket variant should be deprecated eventually.
That makes more sense, (so I take what I said previously back... partly anyway; this way the implementation detail, i.e. the socket type, is hidden from SslUi so that it needs only a KSslErrorUiData).