[FilteredDirIterator] Reduce stack pressure
AbandonedPublic

Authored by hurikhan77 on Tue, Oct 8, 12:26 PM.

Details

Reviewers
None
Group Reviewers
Baloo
Summary

Let's not call ourselves recursively in next() when the currently iterated file is going to be skipped.

Diff Detail

Repository
R293 Baloo
Lint
Lint Skipped
Unit
Unit Tests Skipped
hurikhan77 created this revision.Tue, Oct 8, 12:26 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptTue, Oct 8, 12:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
hurikhan77 requested review of this revision.Tue, Oct 8, 12:26 PM

It is not a good practice to "goto" in C++

Yes, I think you want the concept of a loop with continue.

I think we can also assume that using possibly unlimited recursion is also not good practice.

Let me change that into a proper loop.

bruns added a subscriber: bruns.Wed, Oct 9, 12:39 PM

Let me change that into a proper loop.

See D24502

hurikhan77 abandoned this revision.EditedWed, Oct 9, 2:22 PM

Let's close this in favor of D24502