- User Since
- Oct 8 2019, 12:21 PM (14 w, 5 d)
Oct 12 2019
We need a unique identifier per inode namespace, and for btrfs this is per subvolume and not per disk. Currently, baloo uses QStorageInfo to obtain what it needs. I'll look into Solid and udisks but I fear they will be per disk only, too.
I don't think Baloo should store an index right on the filesystem it's going to index just to get rid of the device id. It seems tempting but I can think of multiple problems:
Looks like looking up the FS UUID can only be done by root (it involves libblkid reading the superblock directly). Does the kernel have some syscall to look that up, or why doesn't it? Also, st_dev is not stable on btrfs (and many other FSes that use virtual devices).
Oct 11 2019
Added depend line according to arc docs
Resend diff with arc
Using single-patch-per-branch approach
Now arc squashed all my commits into one single diff... I'm not sure if I like that.
Rebase and submit with arc
Oct 10 2019
My submission didn't work as expected...
Prevent filesystem thrashing in low-mem situations by turning off
read-ahead. Access patterns of baloo are unlikely to benefit from
read-ahead and preserving cache is more valuable than reading ahead
potentially unused data.
Oct 9 2019
Let's close this in favor of D24502
Oct 8 2019
I think we can also assume that using possibly unlimited recursion is also not good practice.