Add PATH/LD_LIBRARY_PATH to qrcAlias invocation
ClosedPublic

Authored by masonm on Mon, Oct 7, 8:14 PM.

Details

Summary

Build fails to generate binary resource (breeze-icons.rcc) by default. The proposed patch fixes this by adding the QtCore directory to the qrcAlias command invocation.

Test Plan
  1. In root of breeze-icons project generate the project using CMake with install prefix set
  2. The resultant makefiles or .vcxproj files should have PATH=<path to qt core> (on Windows) and LD_LIBRARY_PATH=<path to qt core> (on Unix)
  3. Build the install target
  4. Verify that breeze-icons.rcc was successfully copied to <install prefix>/bin/data/icons/breeze
  5. Same as 3 but for breeze-icons-dark.rcc

Note: it must be tested when Qt is not already in the PATH or LD_LIBRARY_PATH

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
masonm created this revision.Mon, Oct 7, 8:14 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Oct 7, 8:14 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
masonm requested review of this revision.Mon, Oct 7, 8:14 PM
masonm added a reviewer: VDG.Mon, Oct 7, 11:31 PM
ndavis accepted this revision.Thu, Oct 10, 2:05 AM
This revision is now accepted and ready to land.Thu, Oct 10, 2:05 AM
ndavis retitled this revision from [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation to Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.Thu, Oct 10, 2:05 AM
This revision was automatically updated to reflect the committed changes.

For some reason, Arc made me the committer and the author instead of just the committer.

For some reason, Arc made me the committer and the author instead of just the committer.

Maybe because patches sent through the phabricator web interface have no authorship information. Please revert, apply the same commit again but amend it with the proper authorship information and then commit again.