Fix include path to kjob.h
ClosedPublic

Authored by hallas on Sun, Oct 6, 5:24 AM.

Details

Summary

Fix include path to kjob.h. When kcoreaddons is installed all the
headers files are installed in the same directory, so we shouldn't use
jobs/ when including files from public header files.

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17350
Build 17368: arc lint + arc unit
hallas created this revision.Sun, Oct 6, 5:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Oct 6, 5:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
hallas requested review of this revision.Sun, Oct 6, 5:24 AM
hallas added a comment.Sun, Oct 6, 5:26 AM

@dfaure - I just found that if you include KListOpenFilesJob from e.g. Dolphin then it fails because it cannot include jobs/kjob.h :(

It would be really nice to have this commit in the coming Frameworks release, do you think that is possible?

Sorry for all these late fixes :/

vkrause accepted this revision.Sun, Oct 6, 9:02 AM
This revision is now accepted and ready to land.Sun, Oct 6, 9:02 AM
dfaure added a comment.Sun, Oct 6, 9:42 AM

Argh, I retagged, but this wasn't pushed yet.
Landing and retagging again...

dfaure closed this revision.Sun, Oct 6, 9:43 AM

Argh, I retagged, but this wasn't pushed yet.
Landing and retagging again...

Thanks a lot and sorry for the screwups :D