Add standard icons to support to all entries in QDialogButtonBox
ClosedPublic

Authored by GB_2 on Oct 4 2019, 7:32 PM.

Details

Summary

BUG: 398973
Implement the new enumarations introduced in Qt 5.14: https://codereview.qt-project.org/c/qt/qtbase/+/254494/

Test Plan

Can't really test since Qt 5.14 is not released yet, but QDialogButtonBox buttons should now all have icons.

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Oct 4 2019, 7:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 4 2019, 7:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Oct 4 2019, 7:32 PM
GB_2 added a subscriber: davidedmundson.
dhaumann added inline comments.
src/kstyle/kstyle.cpp
423

Instead of 0x050E00 you could use the macro QT_VERSION_CHECK(5, 14, 0). This would be a bit more self explanatory.

ndavis added a subscriber: ndavis.Oct 4 2019, 11:17 PM
ndavis added inline comments.
src/kstyle/kstyle.cpp
429

why not document-save-all?

GB_2 updated this revision to Diff 67336.Oct 5 2019, 7:54 AM
GB_2 marked 2 inline comments as done.

Address comments

ngraham accepted this revision.Oct 5 2019, 1:55 PM
This revision is now accepted and ready to land.Oct 5 2019, 1:55 PM
davidedmundson accepted this revision.Oct 5 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.