Differential D24252

Make OK button configurable in KMessageBox::sorry/detailedSorry
ClosedPublic
Actions

Authored by dfaure on Sep 26 2019, 8:57 PM.

Details

Reviewers
cfeck
vkrause
apol
Commits
R236:e6438e379961: Make OK button configurable in KMessageBox::sorry/detailedSorry
Summary

A kdialog user requested being able to set it to e.g. "Abort",
and indeed it's weird that yes/no buttons are configurable for other
diaog types but not OK.

Test Plan

Updated test program

Diff Detail

Repository
R236 KWidgetsAddons
Branch
2019_09_okbutton_configurable
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17113
Build 17131: arc lint + arc unit
dfaure created this revision.Sep 26 2019, 8:57 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 26 2019, 8:57 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Sep 26 2019, 8:57 PM
dfaure updated this revision to Diff 66932.Sep 27 2019, 12:27 AM
dfaure retitled this revision from Make OK button configurable in KMessageBox::detailedSorry to Make OK button configurable in KMessageBox::sorry/detailedSorry.

also add this to sorry(); fix inconsistency with Options arg, that one can still have a default value

cfeck added a comment.Sep 27 2019, 9:58 AM

I think it needs to be named 'buttonOk' instead of 'buttonOK'.

dfaure updated this revision to Diff 66975.Sep 27 2019, 9:33 PM

perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.*

apol accepted this revision.Oct 1 2019, 10:52 AM
This revision is now accepted and ready to land.Oct 1 2019, 10:52 AM
dfaure closed this revision.Oct 2 2019, 8:19 AM

Revision Contents
Changeset List

PathPackages
Msrc/kmessagebox.h (90 lines)
Msrc/kmessagebox.cpp (48 lines)
Mtests/kmessageboxtest.cpp (4 lines)

Diff 66975

View Options

src/kmessagebox.h

Loading...
View Options

src/kmessagebox.cpp

Loading...
View Options

tests/kmessageboxtest.cpp

Loading...