Port the pager applet away from QtWidgets

Authored by davidedmundson on Sep 26 2019, 9:48 AM.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Sep 26 2019, 9:48 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 26 2019, 9:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure requested review of this revision.Sep 26 2019, 9:48 AM
broulik added inline comments.

Isn't that the combined geometry of all screens, not just a single screen?

dfaure added inline comments.Sep 26 2019, 2:01 PM

Oh indeed. But then this was the wrong thing to use anyway. You don't want to center the window in relation to the combined geometry, as the documentation of QDesktopWidget rightfully says.

Not that I really understand this code, I admit.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 25 2019, 5:30 PM
This revision was automatically updated to reflect the committed changes.
ognarb reopened this revision.Dec 11 2019, 2:06 PM

Oh I see.

Is there a non-deprecated method to get the overall geometry of all screens combined, or do we need to iterate over the list of screens?
Surprising that this doesn't seem to be anywhere in the API .... !?

Further research leads to this possible patch http://www.davidfaure.fr/2019/windowmodel.cpp.diff

Fix pushed https://commits.kde.org/plasma-desktop/2b5e86323f180f0c51ef9af898a69a522bc379ad after the bug reporter confirmed it fixes the bug.

Reopening this after it was committed is a bit weird. I can't close it, please do.

davidedmundson commandeered this revision.Dec 14 2019, 10:11 AM
davidedmundson added a reviewer: dfaure.
dfaure accepted this revision.Dec 14 2019, 10:12 AM
This revision is now accepted and ready to land.Dec 14 2019, 10:12 AM

@dfaure You can commandeer and then click close

Ah, right. Thanks.