Differential D24147

fix compatibility with Qt5.11
ClosedPublic
Actions

Authored by mgallien on Sep 22 2019, 4:51 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:d2570246a555: fix compatibility with Qt5.11
Summary

Kirigami2 requires Qt 5.11 but D22974 broke that promises

Test Plan

Elisa runs fine against Qt5.11

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16889
Build 16907: arc lint + arc unit
mgallien created this revision.Sep 22 2019, 4:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 22 2019, 4:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mgallien requested review of this revision.Sep 22 2019, 4:51 PM
broulik added a subscriber: broulik.Sep 23 2019, 12:39 PM
broulik added inline comments.
src/controls/ActionToolBar.qml
173

I don't think you can replace arrow functions by a simple assignment. Isn't this just a hack to turn that list into an Array?

mgallien updated this revision to Diff 66666.Sep 23 2019, 3:23 PM

correct modifications from arrow function to a simple short one

mgallien added inline comments.Sep 23 2019, 3:28 PM
src/controls/ActionToolBar.qml
173

Thanks for the review. I was ignorant of arrow functions. The new version should fix that.

mart accepted this revision.Sep 24 2019, 3:13 PM
This revision is now accepted and ready to land.Sep 24 2019, 3:13 PM
Closed by commit R169:d2570246a555: fix compatibility with Qt5.11 (authored by mgallien). · Explain WhySep 24 2019, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66627

View Options

src/controls/Action.qml

Loading...
View Options

src/controls/ActionToolBar.qml

Loading...
View Options

src/controls/ListSectionHeader.qml

Loading...