It is a bad idea to depend on non-existent versions: we should more clearly mark our intended QQC dependency version (ie. Qt 5.12 at a minimum) by refering to an actual release.
While technically correct, non-existent dependency versions such as 2.5 and 2.7 are confusing and causing people to mistakenly propose downstream patches to fix imagined 'typos', cf.: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940966
Details
Details
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- bump-qcc2-to-qt-5.12
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16969 Build 16987: arc lint + arc unit
Comment Actions
Kirigami itself depends on 5.11 https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html
Comment Actions
we have to depend from 2 qt versions ago as per KDE frameworks policy, so max version that can be used is Qt 5.11
Comment Actions
If Kirigami is supposed to depend on Qt 5.11, then *why* were these old imports there in the first place? They cannot work with Qt 5.11, because then the max QQC version is 2.4
Maybe I am misunderstanding something here? Are you saying the old Kirigami code effectively broke its own policy on depending on (newer) Qt versions?
Comment Actions
And if so, sure I can 'fix' this by downgrading to QQC 2.4 instead but in that case: is this 'safe'? I.e. does this introduce bugs/regressions?