Move "Full Screen Mode" item from Settings menu to View menu
ClosedPublic

Authored by ngraham on Sep 19 2019, 4:21 PM.

Details

Summary

This is a pretty longstanding feature request and all the HIG and VDG people polled
were in favor. Since those were the people requested to sign off on it, it looks like
we can make the necessary code change now.

BUG: 106807
FIXED-IN: 5.63

Test Plan

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sep 19 2019, 4:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 19 2019, 4:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 19 2019, 4:21 PM
ndavis accepted this revision.Sep 19 2019, 4:32 PM
This revision is now accepted and ready to land.Sep 19 2019, 4:32 PM

Do you think I should always have a separator above the Full Screen menu item? This should generally work fine, but it means that in case the MergeLocal content is empty, there will be two separators in a row. I don't know how likely this is to ever happen, but it could. Thoughts?

ngraham edited the summary of this revision. (Show Details)Sep 19 2019, 4:46 PM

Do you think I should always have a separator above the Full Screen menu item? This should generally work fine, but it means that in case the MergeLocal content is empty, there will be two separators in a row. I don't know how likely this is to ever happen, but it could. Thoughts?

I'm not sure what MergeLocal does or when it would be empty.

@cfeck can clarify, but I believe it specifies the location of locally-added actions that come from the app itself. It would be empty if the app has a View menu but doesn't add any of its own actions (which seems unlikely, but is theoretically possible).

Alternatively we could remove the separator below redisplay, which would allow us to always have a separator above Full Screen Mode with no danger of ever having double separators.

dfaure added a subscriber: dfaure.Sep 20 2019, 12:34 PM

You can never end up with double separators, QMenu takes care of that.

ngraham added a comment.EditedSep 20 2019, 1:33 PM

Oh perfect, then this can land with the extra separator. Thanks!

ngraham updated this revision to Diff 66541.Sep 20 2019, 2:05 PM

Add safe extra separator

ngraham edited the test plan for this revision. (Show Details)Sep 20 2019, 2:06 PM
This revision was automatically updated to reflect the committed changes.