Please do not split the messages just for sake of column width.

What about just removing the + to concatenate the strings, and just use normal continuation, i.e.:

text: i18n("Are you sure you want to disable all outputs? "
           "This might render the device unusable.")

In D23783#527562, @pino wrote:

Please do not split the messages just for sake of column width.

If there is a better solution than splitting text with a + while still respecting the line chars limit I will upload a new patch.

What about just removing the + to concatenate the strings, and just use normal continuation, i.e.:

text: i18n("Are you sure you want to disable all outputs? "
           "This might render the device unusable.")

This sadly didn't work. The KCM just doesn't start then with an error message. Does the macro need to be improved to support this?

In D23783#527575, @romangg wrote:

In D23783#527562, @pino wrote:

Please do not split the messages just for sake of column width.

If there is a better solution than splitting text with a + while still respecting the line chars limit I will upload a new patch.

Even reading the other RR, I still do not understand how this 100 chars limit is so important, even to make i18n worse.

What about just removing the + to concatenate the strings, and just use normal continuation, i.e.:

text: i18n("Are you sure you want to disable all outputs? "
           "This might render the device unusable.")

This sadly didn't work. The KCM just doesn't start then with an error message. Does the macro need to be improved to support this?

Which macro?

In D23783#527579, @pino wrote:

Which macro?

i18n(...) or "function"?

In D23783#527581, @romangg wrote:

In D23783#527579, @pino wrote:

Which macro?

i18n(...) or "function"?

It's a normal QML function ...

diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml
index 2e61aa5..191daf3 100644
--- a/kcm/package/contents/ui/main.qml
+++ b/kcm/package/contents/ui/main.qml
@@ -41,8 +41,8 @@ KCM.SimpleKCM {
 
             Layout.fillWidth: true
             type: Kirigami.MessageType.Warning
-            text: i18n("Are you sure you want to disable all outputs? ") +
-                  i18n("This might render the device unusable.")
+            text: i18n("Are you sure you want to disable all outputs? \
+This might render the device unusable.")
             showCloseButton: true
 
             actions: [

This also works, but it's ugly because the second line has not the right indent.

In D23783#527600, @romangg wrote:

diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml
index 2e61aa5..191daf3 100644
--- a/kcm/package/contents/ui/main.qml
+++ b/kcm/package/contents/ui/main.qml
@@ -41,8 +41,8 @@ KCM.SimpleKCM {
 
             Layout.fillWidth: true
             type: Kirigami.MessageType.Warning
-            text: i18n("Are you sure you want to disable all outputs? ") +
-                  i18n("This might render the device unusable.")
+            text: i18n("Are you sure you want to disable all outputs? \
+This might render the device unusable.")
             showCloseButton: true
 
             actions: [

This also works, but it's ugly because the second line has not the right indent.

Pick your choice: this, or single-line messages. Either of them is way better than the currently committed hack.

In D23783#527562, @pino wrote:

Please do not split the messages just for sake of column width.

What about just removing the + to concatenate the strings, and just use normal continuation, i.e.:

text: i18n("Are you sure you want to disable all outputs? "
           "This might render the device unusable.")

If I recall correctly, the grammar of ECMAScript doesn't allow such things.

In D23783#527582, @pino wrote:

It's a normal QML function ...

If it's just a QML function why is it a problem to + some strings when providing them as an argument?

EDIT: I noticed there was an additional white space in the first version. Could this be the problem?

In D23783#527719, @romangg wrote:

In D23783#527582, @pino wrote:

It's a normal QML function ...

If it's just a QML function why is it a problem to + some strings when providing them as an argument?

This is not a "problem" when translating the string at runtime, but rather when extracting it (with xgettext).
(x)gettext extracts only string literals, and a string concatenation is not (they are two strings, actually). This is why continuation lines do not pose issue: they are still a single literal string.

BTW: if by 2200 UTC none of the two solutions mentioned above (continuation lines, or single long lines) is implemented, I will revert the majority of a798e78d477e (leaving only the .pot renaming, which is correct).

@ltoscano The plus sign does not work.

This string:

text: i18n("Are you sure you want to disable all outputs? " +
           "This might render the device unusable.")

is extracted like Are you sure you want to disable all outputs?

@aspotashev: please read the discussion in this review request...

Need to add this patch.

In D23783#535434, @victorr wrote:

Need to add this patch.

kscreen-5.16.90.patch433 BDownload

Need to fix the wrong -DTRANSLATION_DOMAIN