Make KWin action menu consistent with task manager, use action verbs for configure items and add more icons
ClosedPublic

Authored by GB_2 on Sep 7 2019, 10:07 PM.

Details

Summary

Test Plan

Open the context menu for a window (Alt+F3).

Diff Detail

Repository
R108 KWin
Branch
make-actions-context-menu-consistent-with-task-manager (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 16243
Build 16261: arc lint + arc unit
GB_2 created this revision.Sep 7 2019, 10:07 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 7 2019, 10:07 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
GB_2 requested review of this revision.Sep 7 2019, 10:07 PM
GB_2 updated this revision to Diff 65610.Sep 7 2019, 10:08 PM

Make more changes

GB_2 updated this revision to Diff 65611.Sep 7 2019, 10:14 PM

Don't change "All Activities" mnemonic

ndavis accepted this revision.Sep 7 2019, 11:12 PM
ndavis added a subscriber: ndavis.

+1. Not sure about the icon choice for No Borders, but I don't have any better ideas.

This revision is now accepted and ready to land.Sep 7 2019, 11:12 PM
GB_2 updated this revision to Diff 65633.Sep 8 2019, 7:21 AM

Use edit-none-border (edit-none will be the fallback).

GB_2 updated this revision to Diff 65634.Sep 8 2019, 7:23 AM

edit-none-borders -> edit-none-border

davidedmundson accepted this revision.Sep 8 2019, 8:02 AM
davidedmundson added a subscriber: davidedmundson.

Keeping them in sync makes sense. +++

My comment applies to both here and taskmanager. I'd like you to have a brainstorm on that.

useractions.cpp
651

I don't like this one as the behaviour doesn't "move" the window.

GB_2 added inline comments.Sep 8 2019, 8:20 AM
useractions.cpp
651

Yeah, "Show in Activities" is more accurate. I'll change it to that.

GB_2 updated this revision to Diff 65637.Sep 8 2019, 8:32 AM

"Move to Activity" -> "Show in Activities"

GB_2 marked 2 inline comments as done.Sep 8 2019, 8:37 AM
GB_2 edited the summary of this revision. (Show Details)Sep 8 2019, 8:46 AM
This revision was automatically updated to reflect the committed changes.
trickyricky26 added inline comments.
useractions.cpp
289

If I'm not mistaken, this icon is currently not in the Breeze icon theme and is added in D23782. Not sure if this should have been used here already, but adding this comment for reference in D23782.

GB_2 added inline comments.Sep 8 2019, 10:59 AM
useractions.cpp
289

It currently falls back to edit-none thanks to the name. If an entirely different icon should be used I can make a new commit or patch.