FcSolveSolver: cleanup ressources
ClosedPublic

Authored by fabiank on Aug 29 2019, 4:34 PM.

Details

Summary

The FcSolveSolver did not call its free function in patsolve, leading to
ressource exhaustion.

Fixes: BUG-395624

Diff Detail

Repository
R410 KPatience
Branch
simplefix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16224
Build 16242: arc lint + arc unit
fabiank created this revision.Aug 29 2019, 4:34 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 29 2019, 4:34 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
fabiank requested review of this revision.Aug 29 2019, 4:34 PM
fabiank added a subscriber: wbauer.

This is hopefully already a minimal fix for the crash issues, and it does not depend on Qt 5.12 features. @wbauer It would be most helpful if you could test whether the original bug is indeed no longer occurring after this patch.

wbauer added a comment.EditedAug 29 2019, 5:08 PM

This is hopefully already a minimal fix for the crash issues, and it does not depend on Qt 5.12 features. @wbauer It would be most helpful if you could test whether the original bug is indeed no longer occurring after this patch.

JFYI, I already tested the QScopeGuard fix from D23404 today, it alone does indeed fix the crash of BUG 395624.

I'll give this a try too of course.

One note right now though:
You should change "Fixes: BUG-395624" to "BUG: 395624" in the description, then the bug report will be auto-closed when you commit this... ;-)

[spam comment removed by sysadmin]

wbauer accepted this revision.Aug 29 2019, 6:15 PM

Yes, this does fix the crash as well, and it builds fine with Qt 5.9.

So from my side it's good to go in.

I'd suggest to push to the stable Applications/19.08 branch, but that likely was the intention anyway.

This revision is now accepted and ready to land.Aug 29 2019, 6:15 PM
aacid accepted this revision.Sep 2 2019, 5:38 PM
fabiank updated this revision to Diff 65593.Sep 7 2019, 6:48 PM

(include BUG line)

fabiank closed this revision.Sep 7 2019, 6:48 PM