- User Since
- Mar 5 2016, 10:19 AM (154 w, 3 d)
Thu, Feb 14
- Avoid having a virtual solverFormat().
@aacid : well, there are similar solverFormat() methods in Freecell and in Simple Simon, but they all can be non-virtual and I guess a static_cast will work.
Wed, Feb 13
@aacid : re making it pure virtual that would require every subclass to supply it and it isn't needed or used by many of the game variant subclasses.
Sat, Feb 9
Convert to qCCritical and fix a typo.
Fri, Feb 8
Thu, Feb 7
@aacid : OK, thanks for the review. I think I will commit my changes.
Tue, Feb 5
- avoid compile warnings.
First 20,000 deals:
Better formatted table:
For the record, the kpat cmd line I used was ./kpat --start 1 --end 1000000 --solve 12 2>&1 | tee -a new-golfs.txt
I found out that kpat has a command line range solving mode. Here are the results of the first 5,000 deals:
Mon, Feb 4
@aacid : for deal no. 5 (starting position) the old solver reports that "This game cannot be won", while my solver solves it quickly and to completion. I can try collecting statistics on a range of deals wrt the performance of the two solvers.
Fri, Feb 1
Sun, Jan 27
Fixes and cleanups.
Nov 3 2018
Oct 31 2018
Oct 30 2018
Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH .
- Include prefix was restored in v5.0.0 of fcs.
Oct 20 2018
Looks good and runs fine. +1.
Oct 19 2018
Oct 18 2018
Can this change be applied? Is there anything else to be done?
Oct 13 2018
Sorry - this should be applied against https://phabricator.kde.org/D16176 .
Oct 12 2018
Move under autotests per the KDE convention.
Oct 11 2018
Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?
Oct 10 2018
avoid mentioning my contributions to a dependency.
Perhaps use the RNG code from https://fc-solve.shlomifish.org/faq.html#what_are_ms_deals which can handle up to 2**33 deal indices. Furthermore, does this code have unit tests?
Jul 28 2018
Jun 30 2018
May 24 2018
@cgiboudeaux : you're welcome.
@cgiboudeaux : please see the patch in this commit - https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876 - i was aware of these warnings, but ignored them because the fix made performance suffer a little.
May 22 2018
Thanks, Fabian, and - you are welcome!
May 14 2018
@fabiank : from what I seem to recall, that new file was derived from an existing one that carried that copyright. I on my part disclaim any ownership for my modifications to this file.
May 13 2018
hi! Can you please review the second (and the latest) patch?
Apr 24 2018
Update to the master branch and apply commentary from the reviewers - no iostream, no kDebug, precanned solving themes, etc.