shlomif (Shlomi Fish)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 10:19 AM (213 w, 1 d)
Availability
Available

Recent Activity

Tue, Mar 24

shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

Thanks, but you need to update the diff using arc rather than providing a link to a new patch file.

https://community.kde.org/Infrastructure/Phabricator#Step_2:_Update_your_diff_in_response_to_review_comments

Tue, Mar 24, 9:23 PM · Dolphin
shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

@ngraham @meven : here is a new patch: https://www.shlomifish.org/Files/files/code/dolphin--shlomif-patch-D26362--modified-v0.2.0.patch but note that it makes no difference and om fedora 32 x64 it seems that pressing enter twice invokes the top item in the results which was already selected. It also can be done as "down arrow; enter" using either of my patches.

Tue, Mar 24, 5:05 PM · Dolphin
shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

@ngraham : hi! I am interested in finishing it up, but will be fine with someone else doing that. I'll try to get to it soon.

Tue, Mar 24, 4:08 PM · Dolphin

Jan 19 2020

shlomif committed R410:37ec25b07458: Readability improvement per coates' advice. (authored by shlomif).
Readability improvement per coates' advice.
Jan 19 2020, 10:18 AM
shlomif committed R410:7b066470803d: Use specialized QRandomGenerator methods. (authored by shlomif).
Use specialized QRandomGenerator methods.
Jan 19 2020, 10:18 AM
shlomif committed R410:e95e8f012983: fix the non-randomised deal problem. (authored by shlomif).
fix the non-randomised deal problem.
Jan 19 2020, 10:18 AM
shlomif closed D26201: Port away from KRandom.
Jan 19 2020, 10:18 AM
shlomif committed R410:e6b2c641ff2e: Port away from KRandom (authored by nicolasfella).
Port away from KRandom
Jan 19 2020, 10:18 AM

Jan 16 2020

shlomif updated the diff for D26201: Port away from KRandom.
  • Readability improvement per coates' advice.
Jan 16 2020, 5:44 PM
shlomif updated the diff for D26201: Port away from KRandom.
  • fix the non-randomised deal problem.
  • Use specialized QRandomGenerator methods.
Jan 16 2020, 4:28 PM

Jan 3 2020

shlomif updated the diff for D26362: [Tentative] Move from the searchbox to the results.

Convert to emit signal per @ngraham 's comment.

Jan 3 2020, 2:49 PM · Dolphin

Jan 2 2020

shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

As far as I can tell, currently the focus will change from the searchbar to the view when you press <Enter>.
Would that be an acceptable workflow?

Jan 2 2020, 6:10 PM · Dolphin
shlomif requested changes to D26201: Port away from KRandom.

Here is a fixed startRandom():

Jan 2 2020, 2:07 PM
shlomif requested review of D26362: [Tentative] Move from the searchbox to the results.
Jan 2 2020, 1:02 PM · Dolphin

Dec 24 2019

shlomif added a comment to D26201: Port away from KRandom.

Thanks for the patch! It looks fine at first glance, but I noticed that when you deal the first game after the game variant carousel ([kpat start] → Freecell) the deal index in the window's title is always "1". It doesn't happen with the current git master ( 96de699e8fe1b6c56881b29761384b5a600ad6ab ).

Dec 24 2019, 10:23 AM

Aug 14 2019

shlomif committed R410:5b8ab87deb6d: Silence some compile-time or run-time warnings. (authored by shlomif).
Silence some compile-time or run-time warnings.
Aug 14 2019, 6:21 PM
shlomif committed R410:016348f2560e: Fix the tests+build on the CI and elsewhere. (authored by shlomif).
Fix the tests+build on the CI and elsewhere.
Aug 14 2019, 11:11 AM

Aug 11 2019

shlomif committed R410:0e3f93dda33a: Add SimpleSimonSolverIterationsLimit. (authored by shlomif).
Add SimpleSimonSolverIterationsLimit.
Aug 11 2019, 11:31 AM
shlomif committed R410:c42f572d01c8: Create a FreecellSolverIterationsLimit setting. (authored by shlomif).
Create a FreecellSolverIterationsLimit setting.
Aug 11 2019, 11:31 AM
shlomif closed D23046: Create a FreecellSolverIterationsLimit setting..
Aug 11 2019, 11:31 AM

Aug 9 2019

shlomif requested review of D23046: Create a FreecellSolverIterationsLimit setting..
Aug 9 2019, 2:13 PM
shlomif committed R410:5bbbf028e19f: Initialize to a default value. (authored by shlomif).
Initialize to a default value.
Aug 9 2019, 8:29 AM
shlomif committed R410:c34192cb4a97: Add a Settings() for golfSolverIterationsLimit. (authored by shlomif).
Add a Settings() for golfSolverIterationsLimit.
Aug 9 2019, 8:29 AM
shlomif committed R410:94d8917b8215: Optimize by imcreasing the CHUNKSIZE. (authored by shlomif).
Optimize by imcreasing the CHUNKSIZE.
Aug 9 2019, 8:29 AM
shlomif committed R410:ca2ee65001fa: Add a test for golf solver wins. (authored by shlomif).
Add a test for golf solver wins.
Aug 9 2019, 8:29 AM

Jul 31 2019

shlomif updated the diff for D22483: Add a Settings() for golfSolverIterationsLimit..
  • Initialize to a default value.
Jul 31 2019, 7:02 PM

Jul 15 2019

shlomif requested review of D22483: Add a Settings() for golfSolverIterationsLimit..
Jul 15 2019, 9:20 PM

Jun 1 2019

shlomif added a comment to D20385: Shorten the freecell solutions..

Seems like it was already pushed in https://phabricator.kde.org/R410:d8c4403f115a69a6b1365ab63d1c7c6787d3f6c3 .

Jun 1 2019, 12:41 PM
shlomif added a comment to D20385: Shorten the freecell solutions..

@aacid : hi, can we land this?

Jun 1 2019, 12:26 PM
shlomif closed D20732: Add an assert as a regression test..

Merged, thanks,

Jun 1 2019, 12:24 PM
shlomif closed D20893: Accept games by name as a parameter to --solve..

Merged, thanks!

Jun 1 2019, 12:19 PM
shlomif closed D21003: Convert from virtual+Q_DECL_OVERRIDE to override..

Merged, thanks!

Jun 1 2019, 12:13 PM

May 14 2019

shlomif committed R410:b6f6462417c0: Fix the path to kpat in the tests. (authored by shlomif).
Fix the path to kpat in the tests.
May 14 2019, 9:02 AM
shlomif committed R410:da5b28a56006: Small optimizations. (authored by shlomif).
Small optimizations.
May 14 2019, 9:02 AM
shlomif committed R410:63515abe2597: accept games by name as a parameter to --solve. (authored by shlomif).
accept games by name as a parameter to --solve.
May 14 2019, 9:02 AM

May 9 2019

shlomif committed R410:3c76eb871234: Convert from virtual+Q_DECL_OVERRIDE to override. (authored by shlomif).
Convert from virtual+Q_DECL_OVERRIDE to override.
May 9 2019, 8:39 AM

May 3 2019

shlomif requested review of D21003: Convert from virtual+Q_DECL_OVERRIDE to override..
May 3 2019, 6:58 PM

May 1 2019

shlomif added a reverting change for R410:83bb098c3595: Remove unneeded "virtual"s due to override.: R410:69ae2004a890: Revert "Remove unneeded "virtual"s due to override.".
May 1 2019, 5:14 PM
shlomif committed R410:69ae2004a890: Revert "Remove unneeded "virtual"s due to override." (authored by shlomif).
Revert "Remove unneeded "virtual"s due to override."
May 1 2019, 5:14 PM

Apr 30 2019

shlomif committed R410:892bb7b6355f: Eliminate some GCC warnings during compilation. (authored by shlomif).
Eliminate some GCC warnings during compilation.
Apr 30 2019, 4:01 PM
shlomif committed R410:83bb098c3595: Remove unneeded "virtual"s due to override. (authored by shlomif).
Remove unneeded "virtual"s due to override.
Apr 30 2019, 4:01 PM
shlomif closed D20892: Eliminate some GCC warnings during compilation..
Apr 30 2019, 4:01 PM
shlomif updated the diff for D20892: Eliminate some GCC warnings during compilation..
  • Remove unneeded "virtual"s due to override.
Apr 30 2019, 1:39 PM
shlomif abandoned D20720: Fix for bug 406587 - Freecell Autodrop..

Already applied as part of commit 9b86b67bb33cc011e01ff5466ef88fe80f514583 to git master.

Apr 30 2019, 8:16 AM

Apr 29 2019

shlomif requested review of D20893: Accept games by name as a parameter to --solve..
Apr 29 2019, 10:54 AM
shlomif requested review of D20892: Eliminate some GCC warnings during compilation..
Apr 29 2019, 9:55 AM

Apr 25 2019

shlomif committed R410:0645d70ef7ea: Fix for bug 406587 - Freecell Autodrop. (authored by shlomif).
Fix for bug 406587 - Freecell Autodrop.
Apr 25 2019, 8:14 AM
shlomif committed R410:9b86b67bb33c: Add an assert as a regression test. (authored by shlomif).
Add an assert as a regression test.
Apr 25 2019, 8:14 AM
shlomif committed R410:d8c4403f115a: Shorten the freecell solutions. (authored by shlomif).
Shorten the freecell solutions.
Apr 25 2019, 8:14 AM

Apr 23 2019

shlomif added a comment to D20611: Compatibility with black-hole-solver 0.20.0..

@arojas: I pushed it to 19.04 too - thanks.

Apr 23 2019, 10:19 AM
shlomif committed R410:43fa807465ad: Compatibility with bh-solver 0.20.0. (authored by shlomif).
Compatibility with bh-solver 0.20.0.
Apr 23 2019, 10:17 AM

Apr 22 2019

shlomif requested review of D20732: Add an assert as a regression test..
Apr 22 2019, 11:34 AM
shlomif committed R410:3d9e8324d505: Add a comment to explain. (authored by shlomif).
Add a comment to explain.
Apr 22 2019, 10:54 AM
shlomif committed R410:1aaa543eb25a: Optimize loading freecell games. (authored by shlomif).
Optimize loading freecell games.
Apr 22 2019, 10:54 AM
shlomif closed D20721: Optimize loading freecell games..
Apr 22 2019, 10:54 AM
shlomif updated the diff for D20721: Optimize loading freecell games..
  • Add a comment to explain.
Apr 22 2019, 9:46 AM
shlomif added a comment to D20720: Fix for bug 406587 - Freecell Autodrop..

I think we can have an autotest for it, but it will require some work.

Apr 22 2019, 9:35 AM

Apr 21 2019

shlomif requested review of D20721: Optimize loading freecell games..
Apr 21 2019, 8:52 PM
shlomif requested review of D20720: Fix for bug 406587 - Freecell Autodrop..
Apr 21 2019, 8:38 PM
shlomif committed R410:a8493952e1b6: Compatibility with bh-solver 0.20.0. (authored by shlomif).
Compatibility with bh-solver 0.20.0.
Apr 21 2019, 5:30 PM
shlomif closed D20611: Compatibility with black-hole-solver 0.20.0..
Apr 21 2019, 5:30 PM

Apr 16 2019

shlomif requested review of D20611: Compatibility with black-hole-solver 0.20.0..
Apr 16 2019, 8:53 PM

Apr 14 2019

shlomif added a comment to D20385: Shorten the freecell solutions..

@aacid : hi, the Expat License is a different (and more accurate) name to what that page calls MIT license. See https://en.wikipedia.org/wiki/MIT_License .

Apr 14 2019, 7:00 PM

Apr 8 2019

shlomif requested review of D20385: Shorten the freecell solutions..
Apr 8 2019, 6:13 PM

Mar 15 2019

shlomif committed R410:7bb41e897c59: Add an assert and a test for bz405187 (authored by shlomif).
Add an assert and a test for bz405187
Mar 15 2019, 11:56 AM
shlomif committed R410:56b4426d764c: Fix fc-solve misbehaving preset. (authored by shlomif).
Fix fc-solve misbehaving preset.
Mar 15 2019, 11:56 AM
shlomif closed D19671: Fix fc-solve misbehaving preset..
Mar 15 2019, 11:56 AM

Mar 12 2019

shlomif updated the diff for D19671: Fix fc-solve misbehaving preset..
  • Add an assert and a test for bz405187
Mar 12 2019, 7:58 AM

Mar 11 2019

shlomif requested review of D19671: Fix fc-solve misbehaving preset..
Mar 11 2019, 1:08 AM

Mar 8 2019

shlomif committed R410:247f710c9164: Extract a cardsListToLine function. (authored by shlomif).
Extract a cardsListToLine function.
Mar 8 2019, 12:14 PM
shlomif committed R410:64882cd6bafd: Refactoring: avoid duplicate code. (authored by shlomif).
Refactoring: avoid duplicate code.
Mar 8 2019, 12:14 PM
shlomif committed R410:773af056a78e: avoid duplicate code. (authored by shlomif).
avoid duplicate code.
Mar 8 2019, 12:14 PM
shlomif committed R410:1fdee0b206eb: Extract cardToRankSuitString() function. (authored by shlomif).
Extract cardToRankSuitString() function.
Mar 8 2019, 12:14 PM

Feb 19 2019

shlomif closed D16104: Add some unit tests for the shuffle algo..

Already committed.

Feb 19 2019, 11:35 AM
shlomif committed R410:17ec0c510f88: Add a test for solverFormat(). (authored by shlomif).
Add a test for solverFormat().
Feb 19 2019, 11:10 AM
shlomif closed D18875: Add a test for solverFormat()..
Feb 19 2019, 11:10 AM

Feb 14 2019

shlomif updated the diff for D18875: Add a test for solverFormat()..
  • Avoid having a virtual solverFormat().
Feb 14 2019, 2:21 PM
shlomif added a comment to D18875: Add a test for solverFormat()..

@aacid : well, there are similar solverFormat() methods in Freecell and in Simple Simon, but they all can be non-virtual and I guess a static_cast will work.

Feb 14 2019, 8:27 AM

Feb 13 2019

shlomif added a comment to D18875: Add a test for solverFormat()..

@aacid : re making it pure virtual that would require every subclass to supply it and it isn't needed or used by many of the game variant subclasses.

Feb 13 2019, 10:52 PM

Feb 9 2019

shlomif updated the diff for D18875: Add a test for solverFormat()..

Convert to qCCritical and fix a typo.

Feb 9 2019, 4:58 PM
shlomif requested review of D18875: Add a test for solverFormat()..
Feb 9 2019, 2:06 PM

Feb 8 2019

shlomif committed R410:fa9f7736dae7: Made the black-hole-solver option more consistent. (authored by shlomif).
Made the black-hole-solver option more consistent.
Feb 8 2019, 1:26 PM

Feb 7 2019

shlomif committed R410:c13de9bc4ddc: Support for solving Golf using bh-solver. (authored by shlomif).
Support for solving Golf using bh-solver.
Feb 7 2019, 8:49 AM
shlomif closed D18566: Support for solving Golf using bh-solver..
Feb 7 2019, 8:49 AM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

@aacid : OK, thanks for the review. I think I will commit my changes.

Feb 7 2019, 8:34 AM

Feb 5 2019

shlomif updated the diff for D18566: Support for solving Golf using bh-solver..
  • avoid compile warnings.
Feb 5 2019, 4:33 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

First 20,000 deals:

Feb 5 2019, 1:40 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

Better formatted table:

Feb 5 2019, 1:08 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

For the record, the kpat cmd line I used was ./kpat --start 1 --end 1000000 --solve 12 2>&1 | tee -a new-golfs.txt

Feb 5 2019, 1:01 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

I found out that kpat has a command line range solving mode. Here are the results of the first 5,000 deals:

Feb 5 2019, 12:58 PM

Feb 4 2019

shlomif added a comment to D18566: Support for solving Golf using bh-solver..

@aacid : for deal no. 5 (starting position) the old solver reports that "This game cannot be won", while my solver solves it quickly and to completion. I can try collecting statistics on a range of deals wrt the performance of the two solvers.

Feb 4 2019, 10:19 PM

Feb 1 2019

shlomif added a comment to D18566: Support for solving Golf using bh-solver..

Any comments?

Feb 1 2019, 3:12 PM

Jan 27 2019

shlomif updated the diff for D18566: Support for solving Golf using bh-solver..

Fixes and cleanups.

Jan 27 2019, 9:01 PM
shlomif requested review of D18566: Support for solving Golf using bh-solver..
Jan 27 2019, 2:31 PM

Nov 3 2018

shlomif committed R410:fdbb63304b9d: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH (authored by shlomif).
Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH
Nov 3 2018, 6:09 PM
shlomif closed D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.
Nov 3 2018, 6:09 PM

Oct 31 2018

shlomif added a comment to D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.

Will this still work with 4.x ?

Oct 31 2018, 9:41 AM

Oct 30 2018

shlomif updated the diff for D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.

Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH .

Oct 30 2018, 3:14 PM
shlomif updated the diff for D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.
  • Include prefix was restored in v5.0.0 of fcs.
Oct 30 2018, 3:09 PM

Oct 20 2018

shlomif accepted D16335: Port to auto-generated categorized logging.

Looks good and runs fine. +1.

Oct 20 2018, 3:51 PM