shlomif (Shlomi Fish)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 10:19 AM (163 w, 4 h)
Availability
Available

Recent Activity

Tue, Apr 16

shlomif requested review of D20611: Compatibility with black-hole-solver 0.20.0..
Tue, Apr 16, 8:53 PM

Sun, Apr 14

shlomif added a comment to D20385: Shorten the freecell solutions..

@aacid : hi, the Expat License is a different (and more accurate) name to what that page calls MIT license. See https://en.wikipedia.org/wiki/MIT_License .

Sun, Apr 14, 7:00 PM

Mon, Apr 8

shlomif requested review of D20385: Shorten the freecell solutions..
Mon, Apr 8, 6:13 PM

Mar 15 2019

shlomif committed R410:7bb41e897c59: Add an assert and a test for bz405187 (authored by shlomif).
Add an assert and a test for bz405187
Mar 15 2019, 11:56 AM
shlomif committed R410:56b4426d764c: Fix fc-solve misbehaving preset. (authored by shlomif).
Fix fc-solve misbehaving preset.
Mar 15 2019, 11:56 AM
shlomif closed D19671: Fix fc-solve misbehaving preset..
Mar 15 2019, 11:56 AM

Mar 12 2019

shlomif updated the diff for D19671: Fix fc-solve misbehaving preset..
  • Add an assert and a test for bz405187
Mar 12 2019, 7:58 AM

Mar 11 2019

shlomif requested review of D19671: Fix fc-solve misbehaving preset..
Mar 11 2019, 1:08 AM

Mar 8 2019

shlomif committed R410:247f710c9164: Extract a cardsListToLine function. (authored by shlomif).
Extract a cardsListToLine function.
Mar 8 2019, 12:14 PM
shlomif committed R410:64882cd6bafd: Refactoring: avoid duplicate code. (authored by shlomif).
Refactoring: avoid duplicate code.
Mar 8 2019, 12:14 PM
shlomif committed R410:773af056a78e: avoid duplicate code. (authored by shlomif).
avoid duplicate code.
Mar 8 2019, 12:14 PM
shlomif committed R410:1fdee0b206eb: Extract cardToRankSuitString() function. (authored by shlomif).
Extract cardToRankSuitString() function.
Mar 8 2019, 12:14 PM

Feb 19 2019

shlomif closed D16104: Add some unit tests for the shuffle algo..

Already committed.

Feb 19 2019, 11:35 AM
shlomif committed R410:17ec0c510f88: Add a test for solverFormat(). (authored by shlomif).
Add a test for solverFormat().
Feb 19 2019, 11:10 AM
shlomif closed D18875: Add a test for solverFormat()..
Feb 19 2019, 11:10 AM

Feb 14 2019

shlomif updated the diff for D18875: Add a test for solverFormat()..
  • Avoid having a virtual solverFormat().
Feb 14 2019, 2:21 PM
shlomif added a comment to D18875: Add a test for solverFormat()..

@aacid : well, there are similar solverFormat() methods in Freecell and in Simple Simon, but they all can be non-virtual and I guess a static_cast will work.

Feb 14 2019, 8:27 AM

Feb 13 2019

shlomif added a comment to D18875: Add a test for solverFormat()..

@aacid : re making it pure virtual that would require every subclass to supply it and it isn't needed or used by many of the game variant subclasses.

Feb 13 2019, 10:52 PM

Feb 9 2019

shlomif updated the diff for D18875: Add a test for solverFormat()..

Convert to qCCritical and fix a typo.

Feb 9 2019, 4:58 PM
shlomif requested review of D18875: Add a test for solverFormat()..
Feb 9 2019, 2:06 PM

Feb 8 2019

shlomif committed R410:fa9f7736dae7: Made the black-hole-solver option more consistent. (authored by shlomif).
Made the black-hole-solver option more consistent.
Feb 8 2019, 1:26 PM

Feb 7 2019

shlomif committed R410:c13de9bc4ddc: Support for solving Golf using bh-solver. (authored by shlomif).
Support for solving Golf using bh-solver.
Feb 7 2019, 8:49 AM
shlomif closed D18566: Support for solving Golf using bh-solver..
Feb 7 2019, 8:49 AM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

@aacid : OK, thanks for the review. I think I will commit my changes.

Feb 7 2019, 8:34 AM

Feb 5 2019

shlomif updated the diff for D18566: Support for solving Golf using bh-solver..
  • avoid compile warnings.
Feb 5 2019, 4:33 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

First 20,000 deals:

Feb 5 2019, 1:40 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

Better formatted table:

Feb 5 2019, 1:08 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

For the record, the kpat cmd line I used was ./kpat --start 1 --end 1000000 --solve 12 2>&1 | tee -a new-golfs.txt

Feb 5 2019, 1:01 PM
shlomif added a comment to D18566: Support for solving Golf using bh-solver..

I found out that kpat has a command line range solving mode. Here are the results of the first 5,000 deals:

Feb 5 2019, 12:58 PM

Feb 4 2019

shlomif added a comment to D18566: Support for solving Golf using bh-solver..

@aacid : for deal no. 5 (starting position) the old solver reports that "This game cannot be won", while my solver solves it quickly and to completion. I can try collecting statistics on a range of deals wrt the performance of the two solvers.

Feb 4 2019, 10:19 PM

Feb 1 2019

shlomif added a comment to D18566: Support for solving Golf using bh-solver..

Any comments?

Feb 1 2019, 3:12 PM

Jan 27 2019

shlomif updated the diff for D18566: Support for solving Golf using bh-solver..

Fixes and cleanups.

Jan 27 2019, 9:01 PM
shlomif requested review of D18566: Support for solving Golf using bh-solver..
Jan 27 2019, 2:31 PM

Nov 3 2018

shlomif committed R410:fdbb63304b9d: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH (authored by shlomif).
Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH
Nov 3 2018, 6:09 PM
shlomif closed D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.
Nov 3 2018, 6:09 PM

Oct 31 2018

shlomif added a comment to D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.

Will this still work with 4.x ?

Oct 31 2018, 9:41 AM

Oct 30 2018

shlomif updated the diff for D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.

Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH .

Oct 30 2018, 3:14 PM
shlomif updated the diff for D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.
  • Include prefix was restored in v5.0.0 of fcs.
Oct 30 2018, 3:09 PM

Oct 20 2018

shlomif accepted D16335: Port to auto-generated categorized logging.

Looks good and runs fine. +1.

Oct 20 2018, 3:51 PM
shlomif committed R410:7ed0e95f1bf4: Fix the licence header of shuffle_test.cpp. (authored by shlomif).
Fix the licence header of shuffle_test.cpp.
Oct 20 2018, 7:49 AM

Oct 19 2018

shlomif committed R410:0310b56e0f3b: Move under autotests per the KDE convention. (authored by shlomif).
Move under autotests per the KDE convention.
Oct 19 2018, 9:42 PM
shlomif committed R410:bf7b4a936b20: Fix the indentation. (authored by shlomif).
Fix the indentation.
Oct 19 2018, 9:42 PM
shlomif committed R410:0062cb25c648: Rename the test class. (authored by shlomif).
Rename the test class.
Oct 19 2018, 9:41 PM
shlomif committed R410:5a4da93f5d66: Extract a common constant. (authored by shlomif).
Extract a common constant.
Oct 19 2018, 9:41 PM
shlomif committed R410:3a6afef52b2b: Extract typedefs. (authored by shlomif).
Extract typedefs.
Oct 19 2018, 9:41 PM
shlomif committed R410:b0009617d3fe: add a test (authored by shlomif).
add a test
Oct 19 2018, 9:41 PM
shlomif committed R410:e9efc23ff12b: start adding the test. (authored by shlomif).
start adding the test.
Oct 19 2018, 9:41 PM
shlomif committed R410:b349091428e8: add shuffle tests. (authored by shlomif).
add shuffle tests.
Oct 19 2018, 9:41 PM
shlomif committed R410:3c5df5ea6969: Extract shuffle.h for easier testing. (authored by shlomif).
Extract shuffle.h for easier testing.
Oct 19 2018, 9:41 PM
shlomif committed R410:3a61f56a6821: Convert to a template to facilitate testing. (authored by shlomif).
Convert to a template to facilitate testing.
Oct 19 2018, 9:41 PM

Oct 18 2018

shlomif added a comment to D16104: Add some unit tests for the shuffle algo..

Can this change be applied? Is there anything else to be done?

Oct 18 2018, 12:01 PM

Oct 13 2018

shlomif added a comment to D16176: Add new solitaire game ‘Midnight’.

@huftis: see https://phabricator.kde.org/D16177 for a fix.

Oct 13 2018, 2:38 PM
shlomif added a comment to D16177: Fix segfaults / nullptr accesses..

Sorry - this should be applied against https://phabricator.kde.org/D16176 .

Oct 13 2018, 1:53 PM
shlomif requested review of D16177: Fix segfaults / nullptr accesses..
Oct 13 2018, 1:48 PM

Oct 12 2018

shlomif updated the diff for D16104: Add some unit tests for the shuffle algo..

Move under autotests per the KDE convention.

Oct 12 2018, 8:38 AM
shlomif added a comment to D16104: Add some unit tests for the shuffle algo..

It's just that, create a folder named autotest and put the tests there :D

You can look at okular source code if you want but there's nothing really more to it

https://cgit.kde.org/okular.git/tree/autotests

Oct 12 2018, 8:12 AM
shlomif accepted D16121: Make sure the card we're trying to automove is the top of the pile.

Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?

Yes, as you can read the bug the only thing you need is have a pile where the last N cards are "correct", e.g. Red J and Black 10, then double click on the Red J and see how it goes to the top left.

Oct 12 2018, 8:11 AM

Oct 11 2018

shlomif added a comment to D16121: Make sure the card we're trying to automove is the top of the pile.

Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?

Oct 11 2018, 10:42 AM

Oct 10 2018

shlomif added a comment to D16104: Add some unit tests for the shuffle algo..

Add an autotests folder?

Most apps have it that way

Oct 10 2018, 9:47 PM
shlomif requested review of D16104: Add some unit tests for the shuffle algo..
Oct 10 2018, 1:32 PM
shlomif updated the diff for D13809: Add Shlomi Fish to the credits.

avoid mentioning my contributions to a dependency.

Oct 10 2018, 11:43 AM
shlomif added a comment to D15716: Suspicious use of signed arithmetic leads to negative index crash.

Perhaps use the RNG code from https://fc-solve.shlomifish.org/faq.html#what_are_ms_deals which can handle up to 2**33 deal indices. Furthermore, does this code have unit tests?

Oct 10 2018, 7:44 AM

Jul 28 2018

shlomif requested review of D14445: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH.
Jul 28 2018, 5:29 PM

Jun 30 2018

shlomif requested review of D13809: Add Shlomi Fish to the credits.
Jun 30 2018, 10:56 AM

May 24 2018

shlomif added a comment to T8802: New dependency for kpat (required for CI).

@cgiboudeaux : you're welcome.

May 24 2018, 1:42 PM · build.kde.org
shlomif added a comment to T8802: New dependency for kpat (required for CI).

@cgiboudeaux : please see the patch in this commit - https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876 - i was aware of these warnings, but ignored them because the fix made performance suffer a little.

May 24 2018, 11:14 AM · build.kde.org

May 22 2018

shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Thanks, Fabian, and - you are welcome!

May 22 2018, 7:29 PM · KDE Games

May 14 2018

shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

@fabiank : from what I seem to recall, that new file was derived from an existing one that carried that copyright. I on my part disclaim any ownership for my modifications to this file.

May 14 2018, 10:03 AM · KDE Games

May 13 2018

shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

hi! Can you please review the second (and the latest) patch?

May 13 2018, 1:12 PM · KDE Games

Apr 24 2018

shlomif updated the diff for D12415: Use Freecell Solver for FreeCell and Simple Simon.

Update to the master branch and apply commentary from the reviewers - no iostream, no kDebug, precanned solving themes, etc.

Apr 24 2018, 2:59 PM · KDE Games
shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Hi all!

Apr 24 2018, 12:26 PM · KDE Games

Apr 21 2018

shlomif requested review of D12415: Use Freecell Solver for FreeCell and Simple Simon.
Apr 21 2018, 4:27 PM · KDE Games

Oct 13 2017

shlomif created D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp.
Oct 13 2017, 9:33 AM · Frameworks