Get name and refresh rate from output device
ClosedPublic

Authored by romangg on Aug 28 2019, 9:01 PM.

Details

Summary

We can simplify the AbstractWaylandOutput code some more by getting name and
refresh rate of an output from the always available output device object.

Test Plan

Tested with DRM, Wayland nested and virtual backends.

Diff Detail

Repository
R108 KWin
Branch
useOutputDeviceData2
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15776
Build 15794: arc lint + arc unit
romangg created this revision.Aug 28 2019, 9:01 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 28 2019, 9:01 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Aug 28 2019, 9:01 PM
apol added a subscriber: apol.Aug 28 2019, 10:18 PM

Why does outputinterface and outputdevice interface have so much duped API?

Why does outputinterface and outputdevice interface have so much duped API?

KWayland is (at least sometimes) a lowlevel wrapper round the interfaces.
We have two interfaces because we wanted to extend wl_output, but also have a different lifespan on the protocol.

Long term one could think of combining them such that WaylandOutput requires WaylandOutputDevice to exist and get its data directly from it in KWayland. Then we don't need the coupling done here in KWin.

On the other side someone might want to write a compositor without using WaylandOutputDevices. So there needs to be the independent API of WaylandOutput still available.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.