Differential D23388

add a border for the toolbars WIP
Needs ReviewPublic
Actions

Authored by camiloh on Aug 23 2019, 9:00 PM.

Details

Reviewers
mart
ngraham
apol
Group Reviewers
Plasma
Summary

this is mostly mean for the QQC2 apps running on PlaMo and using the Plasma style
to make them more close to the desktop style.

There is the enabledBorders property for PlasmaCore.FrameSvgItem, but for the Breeze style it does not draw any border, so maybe this change, if wanted, should be done on the style asset images?

Before patch:

After patch:

In the previous screenshots the style being used in Breeze, here it is with Air style, which draws the border from its assets:

and with this patch and still Air style:

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
toolbar-styling-border (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15557
Build 15575: arc lint + arc unit
camiloh created this revision.Aug 23 2019, 9:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 23 2019, 9:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
camiloh requested review of this revision.Aug 23 2019, 9:00 PM
camiloh retitled this revision from add a border for the toolbars to add a border for the toolbars WIP.Aug 23 2019, 9:13 PM
camiloh edited the summary of this revision. (Show Details)
camiloh edited the summary of this revision. (Show Details)Aug 23 2019, 9:18 PM
camiloh edited the summary of this revision. (Show Details)
ngraham added a comment.Aug 23 2019, 9:20 PM

Before-and-after pictures would be appreciated. :)

camiloh edited the summary of this revision. (Show Details)Aug 23 2019, 9:25 PM
camiloh edited the summary of this revision. (Show Details)
ngraham added a comment.Aug 23 2019, 9:26 PM

Huge +1 on the visuals. I'll let someone else review this for technical correctness.

camiloh edited the summary of this revision. (Show Details)Aug 23 2019, 9:33 PM
apol added a comment.Aug 24 2019, 12:41 AM

I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle.

camiloh added a comment.Aug 24 2019, 3:50 PM
In D23388#517778, @apol wrote:

I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle.

It seems to take the right color:
In the following screenshots, the style Plasma is using the Breeze Dark theme and another random one, and seem to pick the right border color.

apol added a comment.Aug 25 2019, 12:53 AM

Well it's the same color, it just looks okay. Set the applications' color scheme to another one and you'll see what I mean.

mart added inline comments.Aug 28 2019, 1:51 PM
src/declarativeimports/plasmacomponents3/ToolBar.qml
47

for now you need for now to add there:
Kirigami.Theme.textColor: theme.textColor

Revision Contents
Changeset List

Diff 64448

View Options

src/declarativeimports/plasmacomponents3/ToolBar.qml

Loading...