Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and make the KCM show up in search results.
Details
- Reviewers
ivan ngraham - Group Reviewers
Plasma VDG KActivities - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
T7260: Activities - Commits
- R119:fbd0465c3b1c: Improve the look of the Activities KCM UI
Open the Activities KCM and change some settings. Everything that was working before should still work.
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- improved-activities-kcm-ui (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15132 Build 15150: arc lint + arc unit
UI is super better now, wow.
kcms/activities/ui/PrivacyTabBase.ui | ||
---|---|---|
60 | I'd add a colon after this (Only for specific applications:) because the grid of specific applications is right after it. |
As a further improvement, I might even merge the contents of the "Switching" tab into the main "Activities" tab. There's room below the Activities list because typically people are going to have 1-4 activities at most; it's not generally going to be a huge tall list of dozens of items.
I can understand if that presents tech problems because one is QML and the other is QWidgets though.
Very nice work. This is close to a "shipit" already IMO from my perspective. I just have a few more comments:
kcms/activities/imports/qml/activityDialog/GeneralTab.qml | ||
---|---|---|
26 | You're importing two different things with the same name | |
kcms/activities/qml/activitiesTab/ActivitiesView.qml | ||
66 | Maybe "Configure <activity name> activity..."? | |
73 | Maybe "Delete <activity name> activity"? | |
84 | How about "Create New..." just to emphasize that a new one is being made | |
kcms/activities/qml/privacyTab/BlacklistApplicationView.qml | ||
61 | emblem-unavailable looks nicer and seems more semantically correct. If we use it, it should be located in the bottom-right corner of the icon to be consistent with other emblem placement. |
Hooray!
Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons?
Unfortunately, I don't know the code base well enough to fix that. Maybe @ivan can fix it or you can file a bug.