Differential D23149

Only build tests when DBus is available
ClosedPublic
Actions

Authored by nicolasfella on Aug 14 2019, 10:22 AM.

Details

Reviewers
bcooksley
broulik
bruns
apol
Group Reviewers
Frameworks
Commits
R245:f7149af10e4b: Only build tests when DBus is available
Summary

The tests require DBus

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Aug 14 2019, 10:22 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 14 2019, 10:22 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Aug 14 2019, 10:22 AM
vkrause added a subscriber: vkrause.Aug 14 2019, 1:48 PM
vkrause added inline comments.
CMakeLists.txt
127

Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the tests for everyone I think. Apart from that, +2.

aspotashev added a subscriber: aspotashev.Aug 14 2019, 2:50 PM

Does this mean we cannot test Solid on Windows CI? https://api.kde.org/frameworks/solid/html/ says Solid is supported also on Windows.

aspotashev added a comment.EditedAug 14 2019, 2:51 PM

At least for now Window CI tries and tests something:

https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console

UPD: oh, D-Bus is probably available on Windows...

nicolasfella added a comment.Aug 14 2019, 2:55 PM

Yes, QtDBus is available on Windows, so no change there

nicolasfella marked an inline comment as done.Aug 14 2019, 2:56 PM
apol accepted this revision.Aug 20 2019, 11:21 AM
This revision is now accepted and ready to land.Aug 20 2019, 11:21 AM
Closed by commit R245:f7149af10e4b: Only build tests when DBus is available (authored by nicolasfella). · Explain WhyAug 20 2019, 11:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 64104

View Options

CMakeLists.txt

Loading...