Only build tests when DBus is available
Needs ReviewPublic

Authored by nicolasfella on Wed, Aug 14, 10:22 AM.

Details

Reviewers
bcooksley
broulik
bruns
Group Reviewers
Frameworks
Summary

The tests require DBus

Diff Detail

Repository
R245 Solid
Branch
dbustest
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15091
Build 15109: arc lint + arc unit
nicolasfella created this revision.Wed, Aug 14, 10:22 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Aug 14, 10:22 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Wed, Aug 14, 10:22 AM
vkrause added inline comments.
CMakeLists.txt
127

Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the tests for everyone I think. Apart from that, +2.

Does this mean we cannot test Solid on Windows CI? https://api.kde.org/frameworks/solid/html/ says Solid is supported also on Windows.

aspotashev added a comment.EditedWed, Aug 14, 2:51 PM

At least for now Window CI tries and tests something:

https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console

UPD: oh, D-Bus is probably available on Windows...

Yes, QtDBus is available on Windows, so no change there

nicolasfella marked an inline comment as done.Wed, Aug 14, 2:56 PM