Allow to set maximum volume < 100%
ClosedPublic

Authored by kishoreg on Sun, Aug 11, 3:48 AM.

Details

Summary

Currently one cannot set the maximum volume < 100%. This feature is required because some earphones / speakers are more sensitive than others and may get damaged at high volumes. In particular, one easily ends up overshooting safe volume levels when using the mouse scroll wheel to change the volume. After this change, one can safely use the mouse wheel to change volume.

BUG: 404387
FIXED-IN: 5.17.0

Test Plan
  1. Right-click on applet > 'Configure audio volume'.
  2. Try to set maximum volume < 100% and click 'OK'.
  3. Scroill on the systray icon to change maximum volume. Check if it is limited to the configured maximum.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kishoreg created this revision.Sun, Aug 11, 3:48 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Aug 11, 3:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kishoreg requested review of this revision.Sun, Aug 11, 3:48 AM
ngraham accepted this revision.Sun, Aug 11, 10:07 PM
ngraham added a subscriber: ngraham.

LGTM. I could see this being useful if your hardware had super loud speakers, or if you were deliberately trying to reduce the noisiness of your environment.

This revision is now accepted and ready to land.Sun, Aug 11, 10:07 PM

When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though.

When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though.

Works for me FWIW:

BTW if you accept this patch for Plasma, I can land it right now.

romangg accepted this revision.Sun, Aug 11, 10:29 PM

Thanks for the vid. Also I feel betrayed now by my system.

ngraham edited the summary of this revision. (Show Details)Sun, Aug 11, 10:32 PM
This revision was automatically updated to reflect the committed changes.