Allow to set maximum volume < 100%
ClosedPublic
Actions

Authored by kishoreg on Aug 11 2019, 3:48 AM.

Details

Reviewers

drosca
ngraham
romangg

Group Reviewers

Plasma

Commits

R115:faef1e8f152e: Allow to set maximum volume < 100%

Summary

Currently one cannot set the maximum volume < 100%. This feature is required because some earphones / speakers are more sensitive than others and may get damaged at high volumes. In particular, one easily ends up overshooting safe volume levels when using the mouse scroll wheel to change the volume. After this change, one can safely use the mouse wheel to change volume.

BUG: 404387
FIXED-IN: 5.17.0

Test Plan

Right-click on applet > 'Configure audio volume'.
Try to set maximum volume < 100% and click 'OK'.
Scroill on the systray icon to change maximum volume. Check if it is limited to the configured maximum.

Diff Detail

Repository

R115 Plasma Audio Volume Applet

Lint

Lint Skipped

Unit

Unit Tests Skipped

kishoreg created this revision.Aug 11 2019, 3:48 AM

Restricted Application added a project: Plasma. · View Herald TranscriptAug 11 2019, 3:48 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

kishoreg requested review of this revision.Aug 11 2019, 3:48 AM

ngraham added reviewers: Plasma, drosca.Aug 11 2019, 10:05 PM

LGTM. I could see this being useful if your hardware had super loud speakers, or if you were deliberately trying to reduce the noisiness of your environment.

This revision is now accepted and ready to land.Aug 11 2019, 10:07 PM

When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though.

In D23082#510628, @romangg wrote:

When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though.

Works for me FWIW: