@ngraham There are no issues on the login screen. Everything fits fine there.

Rebase on Plasma/5.17 branch

Is this fine, or should I revert to the previous diff I uploaded?

@filipf Is this better?

The problem is that the original patch was changing the maximum range of the sliders for application streams and microphones as well. This seemed a bit counter-intuitive, as for example capping the volumes of both the speaker and the music player at 15% would lead to an 'effective volume' of 2.25%. There was also the issue that the slider maximum ranges for applications displayed this weird behaviour of having the reduced range applied only after the user interacted with them. In addition, the behaviour was inconsistent with the behaviour when the maximum volume is >100% (it doesn't automatically apply 'raise maximum volume' to application streams, for instance). After applying this patch, the limit only applies to the hardware volume keys and scrolling on the tray icon, which is also consistent with the behaviour when the limit is set to >100%.

In D21831#482108, @aacid wrote:

I'm going to say something wild, can we have it in both categories so you don't break the workflow of people that know kruler has been in Applications->Graphics for years?

Should I submit the patch changing the category in repo-metadata separately?

Put Kruler back in the 'more applications' submenu.

In D21831#481318, @aacid wrote:

Also can you explain why you decided to drop the X-KDE-More?

@elvisangelaccio Would one also have to change the category here (https://phabricator.kde.org/source/kde-build-metadata/browse/master/logical-module-structure$246) in addition to the repo-metadata, or is that done automatically by some script?

Update docs to reflect new category.

Do the same for the ionice slider too.

Added explanatory comment.

Removed colon to keep string unchanged.

In D21414#471615, @ngraham wrote:

With no items in the list view, the size looks perfect to me:

Are you seeing something different?

Moved buttons to the left.

BTW, if I open the window standalone (from krunner), it allows me to resize it vertically so that the entire window gets scrollbars.

Screenshot as of this diff:

This is awkward. I hadn't realized that I was supposed to use one space for indentation. Fixed as per the preexisting convention.

I seem to have messed up the indentation in my previous diff. Here it is with the indentation fixed.

BTW, checkboxes in other KCMs also seem to have the same spacing as this one had before this change. Is there a way to globally apply this spacing / padding consistently to QCheckBoxes in all KCMs for the sake of consistency? Perhaps some sort of global stylesheet that this should go into?

I've added a colon after the 'Do not search in these locations' text. I've also added spacing between the checkboxes and their text. I've put in 10 px for now. Is there a better way to do this?

This patch incorporates Nate's suggestion to remove the box around the 'exclude folders' area. I've added screenshots of all three cases (with spacer, with box, and without box) to a previous comment.

Before change:

I don't think I have the permissions for that. Could you please do it for me?

I've made the suggested changes (use standard reset zoom shortcut, and move zoom option to a submenu). Everything seems to work now.

In D21412#470195, @cullmann wrote:

For the shortcut: I guess you should use KStandardShortcut::ActualSize().

I initially tried using this, but it doesn't compile. It complains that ‘ActualSize’ cannot be used as a function. Just using KStandardShortcut::ActualSize results in the shortcut being set to '8' on my machine.

Get the default font size correctly.