- User Since
- May 1 2019, 4:41 AM (24 w, 15 h)
Sun, Sep 22
@ngraham There are no issues on the login screen. Everything fits fine there.
Rebase on Plasma/5.17 branch
Is this fine, or should I revert to the previous diff I uploaded?
Sep 12 2019
@filipf Is this better?
Sep 8 2019
The problem is that the original patch was changing the maximum range of the sliders for application streams and microphones as well. This seemed a bit counter-intuitive, as for example capping the volumes of both the speaker and the music player at 15% would lead to an 'effective volume' of 2.25%. There was also the issue that the slider maximum ranges for applications displayed this weird behaviour of having the reduced range applied only after the user interacted with them. In addition, the behaviour was inconsistent with the behaviour when the maximum volume is >100% (it doesn't automatically apply 'raise maximum volume' to application streams, for instance). After applying this patch, the limit only applies to the hardware volume keys and scrolling on the tray icon, which is also consistent with the behaviour when the limit is set to >100%.
Sep 7 2019
Aug 11 2019
Jul 18 2019
Jun 19 2019
Should I submit the patch changing the category in repo-metadata separately?
Put Kruler back in the 'more applications' submenu.
Jun 18 2019
Jun 17 2019
@elvisangelaccio Would one also have to change the category here (https://phabricator.kde.org/source/kde-build-metadata/browse/master/logical-module-structure$246) in addition to the repo-metadata, or is that done automatically by some script?
Update docs to reflect new category.
Jun 15 2019
Do the same for the ionice slider too.
Jun 7 2019
Added explanatory comment.
Jun 6 2019
May 29 2019
Removed colon to keep string unchanged.
Moved buttons to the left.
May 28 2019
BTW, if I open the window standalone (from krunner), it allows me to resize it vertically so that the entire window gets scrollbars.
I can't do this horizontally. Is there some vertical minimum size hint I have to set for the entire window? The minimum size is obeyed correctly when we open it as part of the System Settings window. Is this intended behaviour or a known bug? The result is a bit awkward to use, with scrollbars within scrollbars.
Screenshot as of this diff:
This is awkward. I hadn't realized that I was supposed to use one space for indentation. Fixed as per the preexisting convention.
I seem to have messed up the indentation in my previous diff. Here it is with the indentation fixed.
BTW, checkboxes in other KCMs also seem to have the same spacing as this one had before this change. Is there a way to globally apply this spacing / padding consistently to QCheckBoxes in all KCMs for the sake of consistency? Perhaps some sort of global stylesheet that this should go into?
I've added a colon after the 'Do not search in these locations' text. I've also added spacing between the checkboxes and their text. I've put in 10 px for now. Is there a better way to do this?
May 27 2019
This patch incorporates Nate's suggestion to remove the box around the 'exclude folders' area. I've added screenshots of all three cases (with spacer, with box, and without box) to a previous comment.
With box removed:
May 26 2019
I don't think I have the permissions for that. Could you please do it for me?
I've made the suggested changes (use standard reset zoom shortcut, and move zoom option to a submenu). Everything seems to work now.
I initially tried using this, but it doesn't compile. It complains that ‘ActualSize’ cannot be used as a function. Just using KStandardShortcut::ActualSize results in the shortcut being set to '8' on my machine.
Get the default font size correctly.