kishoreg (Kishore Gopalakrishnan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 1 2019, 4:41 AM (15 w, 3 d)
Availability
Available

Recent Activity

Sun, Aug 11

kishoreg requested review of D23082: Allow to set maximum volume < 100%.
Sun, Aug 11, 3:48 AM · Plasma

Jul 18 2019

kishoreg added a comment to D21831: Move Kruler from 'Graphics' category to 'Utilities'.

I'm going to say something wild, can we have it in both categories so you don't break the workflow of people that know kruler has been in Applications->Graphics for years?

Jul 18 2019, 5:52 AM · Documentation

Jun 19 2019

kishoreg added a comment to D21831: Move Kruler from 'Graphics' category to 'Utilities'.

Should I submit the patch changing the category in repo-metadata separately?

Jun 19 2019, 8:04 AM · Documentation
kishoreg updated the diff for D21831: Move Kruler from 'Graphics' category to 'Utilities'.

Put Kruler back in the 'more applications' submenu.

Jun 19 2019, 8:01 AM · Documentation

Jun 18 2019

kishoreg added a comment to D21831: Move Kruler from 'Graphics' category to 'Utilities'.

Also can you explain why you decided to drop the X-KDE-More?

Jun 18 2019, 12:30 PM · Documentation

Jun 17 2019

kishoreg added a comment to D21831: Move Kruler from 'Graphics' category to 'Utilities'.

@elvisangelaccio Would one also have to change the category here (https://phabricator.kde.org/source/kde-build-metadata/browse/master/logical-module-structure$246) in addition to the repo-metadata, or is that done automatically by some script?

Jun 17 2019, 1:20 PM · Documentation
kishoreg updated the diff for D21831: Move Kruler from 'Graphics' category to 'Utilities'.

Update docs to reflect new category.

Jun 17 2019, 1:08 PM · Documentation

Jun 15 2019

kishoreg requested review of D21831: Move Kruler from 'Graphics' category to 'Utilities'.
Jun 15 2019, 11:15 AM · Documentation
kishoreg updated the diff for D21828: Invert controls direction for process priority slider.

Do the same for the ionice slider too.

Jun 15 2019, 10:09 AM · Plasma
kishoreg requested review of D21828: Invert controls direction for process priority slider.
Jun 15 2019, 10:04 AM · Plasma

Jun 7 2019

kishoreg updated the diff for D21620: Handle Esc properly when focus is in searchbox.

Added explanatory comment.

Jun 7 2019, 1:15 PM · Plasma

Jun 6 2019

kishoreg requested review of D21620: Handle Esc properly when focus is in searchbox.
Jun 6 2019, 2:43 PM · Plasma

May 29 2019

kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

Removed colon to keep string unchanged.

May 29 2019, 2:45 PM · Plasma
kishoreg added a comment to D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

With no items in the list view, the size looks perfect to me:

Are you seeing something different?

May 29 2019, 2:36 PM · Plasma
kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

Moved buttons to the left.

May 29 2019, 12:42 PM · Plasma

May 28 2019

kishoreg added a comment to D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

BTW, if I open the window standalone (from krunner), it allows me to resize it vertically so that the entire window gets scrollbars.


I can't do this horizontally. Is there some vertical minimum size hint I have to set for the entire window? The minimum size is obeyed correctly when we open it as part of the System Settings window. Is this intended behaviour or a known bug? The result is a bit awkward to use, with scrollbars within scrollbars.

May 28 2019, 4:41 PM · Plasma
kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

Screenshot as of this diff:

May 28 2019, 4:34 PM · Plasma
kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

This is awkward. I hadn't realized that I was supposed to use one space for indentation. Fixed as per the preexisting convention.

May 28 2019, 1:07 PM · Plasma
kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

I seem to have messed up the indentation in my previous diff. Here it is with the indentation fixed.

May 28 2019, 12:55 PM · Plasma
kishoreg added a comment to D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

BTW, checkboxes in other KCMs also seem to have the same spacing as this one had before this change. Is there a way to globally apply this spacing / padding consistently to QCheckBoxes in all KCMs for the sake of consistency? Perhaps some sort of global stylesheet that this should go into?

May 28 2019, 12:44 PM · Plasma
kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

I've added a colon after the 'Do not search in these locations' text. I've also added spacing between the checkboxes and their text. I've put in 10 px for now. Is there a better way to do this?

May 28 2019, 12:36 PM · Plasma

May 27 2019

kishoreg updated the diff for D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

This patch incorporates Nate's suggestion to remove the box around the 'exclude folders' area. I've added screenshots of all three cases (with spacer, with box, and without box) to a previous comment.

May 27 2019, 1:42 PM · Plasma
kishoreg added a comment to D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.

Before change:


Initial patch:

With box removed:

May 27 2019, 1:37 PM · Plasma

May 26 2019

kishoreg requested review of D21414: Allow 'Exclude folders' section in Baloo KCM to fill window.
May 26 2019, 1:33 PM · Plasma
kishoreg added a comment to D21412: Add action to reset font size.

I don't think I have the permissions for that. Could you please do it for me?

May 26 2019, 11:49 AM · Frameworks, Kate
kishoreg updated the diff for D21412: Add action to reset font size.

I've made the suggested changes (use standard reset zoom shortcut, and move zoom option to a submenu). Everything seems to work now.

May 26 2019, 11:33 AM · Frameworks, Kate
kishoreg added a comment to D21412: Add action to reset font size.

For the shortcut: I guess you should use KStandardShortcut::ActualSize().

I initially tried using this, but it doesn't compile. It complains that ‘ActualSize’ cannot be used as a function. Just using KStandardShortcut::ActualSize results in the shortcut being set to '8' on my machine.

May 26 2019, 10:54 AM · Frameworks, Kate
kishoreg updated the diff for D21412: Add action to reset font size.

Get the default font size correctly.

May 26 2019, 10:51 AM · Frameworks, Kate
kishoreg requested review of D21412: Add action to reset font size.
May 26 2019, 6:10 AM · Frameworks, Kate