Security: remove support for $(...) in config keys with [$e] marker.
ClosedPublic

Authored by broulik on Wed, Aug 7, 11:37 AM.

Details

Summary

It is very unclear at this point what a valid use case for this feature
would possibly be. The old documentation only mentions $(hostname) as
an example, which can be done with $HOSTNAME instead.

Note that $(...) is still supported in Exec lines of desktop files,
this does not require [$e] anyway (and actually works better without it,
otherwise the $ signs need to be doubled to obey kconfig $e escaping rules...).

(This is a backport of KDE Frameworks 5 kconfig patch D22979 to kdelibs)

Test Plan

Thanks to Fabian Vogt for testing.

Diff Detail

Repository
R446 KDE Libraries (legacy)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik requested review of this revision.Wed, Aug 7, 11:37 AM
broulik created this revision.
fvogt added a subscriber: fvogt.Wed, Aug 7, 11:42 AM

Built fine and Icon[$e]=$(kinfocenter) didn't work anymore as expected.

dfaure accepted this revision.Wed, Aug 7, 2:04 PM
This revision is now accepted and ready to land.Wed, Aug 7, 2:04 PM