Security: remove support for $(...) in config keys with [$e] marker.

Authored by broulik on Aug 7 2019, 11:37 AM.



It is very unclear at this point what a valid use case for this feature
would possibly be. The old documentation only mentions $(hostname) as
an example, which can be done with $HOSTNAME instead.

Note that $(...) is still supported in Exec lines of desktop files,
this does not require [$e] anyway (and actually works better without it,
otherwise the $ signs need to be doubled to obey kconfig $e escaping rules...).

(This is a backport of KDE Frameworks 5 kconfig patch D22979 to kdelibs)

Test Plan

Thanks to Fabian Vogt for testing.

Diff Detail

R446 KDE Libraries (legacy)
Lint Skipped
Unit Tests Skipped
broulik requested review of this revision.Aug 7 2019, 11:37 AM
broulik created this revision.
fvogt added a subscriber: fvogt.Aug 7 2019, 11:42 AM

Built fine and Icon[$e]=$(kinfocenter) didn't work anymore as expected.

dfaure accepted this revision.Aug 7 2019, 2:04 PM
This revision is now accepted and ready to land.Aug 7 2019, 2:04 PM